From: Mark Brown <broonie@kernel.org>
To: Andrew Halaney <ahalaney@redhat.com>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
bmasney@redhat.com, dianders@chromium.org
Subject: Re: [PATCH] regulator: core: Clean up on enable failure
Date: Fri, 19 Aug 2022 23:48:42 +0100 [thread overview]
Message-ID: <YwATSglfJEgG6V73@sirena.org.uk> (raw)
In-Reply-To: <20220819194336.382740-1-ahalaney@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 332 bytes --]
On Fri, Aug 19, 2022 at 02:43:36PM -0500, Andrew Halaney wrote:
> - if (regulator->uA_load && regulator->enable_count == 1)
> - return drms_uA_update(rdev);
> + if (regulator->uA_load && regulator->enable_count == 1) {
> + ret = drms_uA_update(rdev);
I am vaugely surprised and a bit concerned that drms_uA_update() can
fail...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-08-19 22:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 19:43 Andrew Halaney
2022-08-19 20:03 ` Doug Anderson
2022-08-19 20:46 ` Brian Masney
2022-08-19 22:48 ` Mark Brown [this message]
2022-08-19 23:03 ` Doug Anderson
2022-08-22 19:42 ` Andrew Halaney
2022-08-22 16:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwATSglfJEgG6V73@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ahalaney@redhat.com \
--cc=bmasney@redhat.com \
--cc=dianders@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®