mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [linux-stable-rc:queue/4.14 13/175] Makefile:877: *** Recursive variable 'LDFLAGS' references itself (eventually).  Stop.
@ 2022-08-20 22:50 kernel test robot
  2022-08-22 17:05 ` Nick Desaulniers
  0 siblings, 1 reply; 5+ messages in thread
From: kernel test robot @ 2022-08-20 22:50 UTC (permalink / raw)
  To: Nick Desaulniers
  Cc: kbuild-all, linux-kernel, Sasha Levin, Greg Kroah-Hartman

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git queue/4.14
head:   ed8a2f4d20af62ebd64e4092d988d4ae6b54657c
commit: 17c47886b521ae64a733f41364def799797e45ef [13/175] Makefile: link with -z noexecstack --no-warn-rwx-segments
config: arc-randconfig-r043-20220821 (https://download.01.org/0day-ci/archive/20220821/202208210645.72NkUj0g-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 7.5.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=17c47886b521ae64a733f41364def799797e45ef
        git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
        git fetch --no-tags linux-stable-rc queue/4.14
        git checkout 17c47886b521ae64a733f41364def799797e45ef
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-7.5.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> Makefile:877: *** Recursive variable 'LDFLAGS' references itself (eventually).  Stop.


vim +/LDFLAGS +877 Makefile

   875	
   876	LDFLAGS	+= -z noexecstack
 > 877	LDFLAGS	+= $(call ld-option,--no-warn-rwx-segments)
   878	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [linux-stable-rc:queue/4.14 13/175] Makefile:877: *** Recursive variable 'LDFLAGS' references itself (eventually). Stop.
  2022-08-20 22:50 [linux-stable-rc:queue/4.14 13/175] Makefile:877: *** Recursive variable 'LDFLAGS' references itself (eventually). Stop kernel test robot
@ 2022-08-22 17:05 ` Nick Desaulniers
  2022-08-22 18:47   ` Nathan Chancellor
  0 siblings, 1 reply; 5+ messages in thread
From: Nick Desaulniers @ 2022-08-22 17:05 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: kbuild-all, linux-kernel, Sasha Levin, Greg Kroah-Hartman,
	kernel test robot, Linus Torvalds

On Sat, Aug 20, 2022 at 3:51 PM kernel test robot <lkp@intel.com> wrote:
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git queue/4.14
> head:   ed8a2f4d20af62ebd64e4092d988d4ae6b54657c
> commit: 17c47886b521ae64a733f41364def799797e45ef [13/175] Makefile: link with -z noexecstack --no-warn-rwx-segments
> config: arc-randconfig-r043-20220821 (https://download.01.org/0day-ci/archive/20220821/202208210645.72NkUj0g-lkp@intel.com/config)
> compiler: arc-elf-gcc (GCC) 7.5.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=17c47886b521ae64a733f41364def799797e45ef
>         git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
>         git fetch --no-tags linux-stable-rc queue/4.14
>         git checkout 17c47886b521ae64a733f41364def799797e45ef
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-7.5.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> >> Makefile:877: *** Recursive variable 'LDFLAGS' references itself (eventually).  Stop.

Thanks for the report!

That's not something that I've seen before...

Masahiro, does ARCH=arc do something special to LDFLAGS?

This report is a randconfig against a branch of stable for arc, so
guessing this might be more obscure than usual.

>
>
> vim +/LDFLAGS +877 Makefile
>
>    875
>    876  LDFLAGS += -z noexecstack
>  > 877  LDFLAGS += $(call ld-option,--no-warn-rwx-segments)
>    878
>
> --
> 0-DAY CI Kernel Test Service
> https://01.org/lkp



-- 
Thanks,
~Nick Desaulniers

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [linux-stable-rc:queue/4.14 13/175] Makefile:877: *** Recursive variable 'LDFLAGS' references itself (eventually). Stop.
  2022-08-22 17:05 ` Nick Desaulniers
@ 2022-08-22 18:47   ` Nathan Chancellor
  2022-08-22 19:16     ` Masahiro Yamada
  0 siblings, 1 reply; 5+ messages in thread
From: Nathan Chancellor @ 2022-08-22 18:47 UTC (permalink / raw)
  To: Nick Desaulniers
  Cc: Masahiro Yamada, kbuild-all, linux-kernel, Sasha Levin,
	Greg Kroah-Hartman, kernel test robot, Linus Torvalds

On Mon, Aug 22, 2022 at 10:05:50AM -0700, Nick Desaulniers wrote:
> On Sat, Aug 20, 2022 at 3:51 PM kernel test robot <lkp@intel.com> wrote:
> >
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git queue/4.14
> > head:   ed8a2f4d20af62ebd64e4092d988d4ae6b54657c
> > commit: 17c47886b521ae64a733f41364def799797e45ef [13/175] Makefile: link with -z noexecstack --no-warn-rwx-segments
> > config: arc-randconfig-r043-20220821 (https://download.01.org/0day-ci/archive/20220821/202208210645.72NkUj0g-lkp@intel.com/config)
> > compiler: arc-elf-gcc (GCC) 7.5.0
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=17c47886b521ae64a733f41364def799797e45ef
> >         git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> >         git fetch --no-tags linux-stable-rc queue/4.14
> >         git checkout 17c47886b521ae64a733f41364def799797e45ef
> >         # save the config file
> >         mkdir build_dir && cp config build_dir/.config
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-7.5.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash
> >
> > If you fix the issue, kindly add following tag where applicable
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All errors (new ones prefixed by >>):
> >
> > >> Makefile:877: *** Recursive variable 'LDFLAGS' references itself (eventually).  Stop.
> 
> Thanks for the report!
> 
> That's not something that I've seen before...
> 
> Masahiro, does ARCH=arc do something special to LDFLAGS?
> 
> This report is a randconfig against a branch of stable for arc, so
> guessing this might be more obscure than usual.

I suspect this would be fixed with commit ce99d0bf312d ("kbuild: clear
LDFLAGS in the top Makefile"), which backports cleanly to 4.14.

Cheers,
Nathan

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [linux-stable-rc:queue/4.14 13/175] Makefile:877: *** Recursive variable 'LDFLAGS' references itself (eventually). Stop.
  2022-08-22 18:47   ` Nathan Chancellor
@ 2022-08-22 19:16     ` Masahiro Yamada
  2022-08-23  6:47       ` Greg Kroah-Hartman
  0 siblings, 1 reply; 5+ messages in thread
From: Masahiro Yamada @ 2022-08-22 19:16 UTC (permalink / raw)
  To: Nathan Chancellor
  Cc: Nick Desaulniers, kbuild-all, Linux Kernel Mailing List,
	Sasha Levin, Greg Kroah-Hartman, kernel test robot,
	Linus Torvalds

On Tue, Aug 23, 2022 at 3:47 AM Nathan Chancellor <nathan@kernel.org> wrote:
>
> On Mon, Aug 22, 2022 at 10:05:50AM -0700, Nick Desaulniers wrote:
> > On Sat, Aug 20, 2022 at 3:51 PM kernel test robot <lkp@intel.com> wrote:
> > >
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git queue/4.14
> > > head:   ed8a2f4d20af62ebd64e4092d988d4ae6b54657c
> > > commit: 17c47886b521ae64a733f41364def799797e45ef [13/175] Makefile: link with -z noexecstack --no-warn-rwx-segments
> > > config: arc-randconfig-r043-20220821 (https://download.01.org/0day-ci/archive/20220821/202208210645.72NkUj0g-lkp@intel.com/config)
> > > compiler: arc-elf-gcc (GCC) 7.5.0
> > > reproduce (this is a W=1 build):
> > >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > >         chmod +x ~/bin/make.cross
> > >         # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=17c47886b521ae64a733f41364def799797e45ef
> > >         git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> > >         git fetch --no-tags linux-stable-rc queue/4.14
> > >         git checkout 17c47886b521ae64a733f41364def799797e45ef
> > >         # save the config file
> > >         mkdir build_dir && cp config build_dir/.config
> > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-7.5.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash
> > >
> > > If you fix the issue, kindly add following tag where applicable
> > > Reported-by: kernel test robot <lkp@intel.com>
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > > >> Makefile:877: *** Recursive variable 'LDFLAGS' references itself (eventually).  Stop.
> >
> > Thanks for the report!
> >
> > That's not something that I've seen before...
> >
> > Masahiro, does ARCH=arc do something special to LDFLAGS?
> >
> > This report is a randconfig against a branch of stable for arc, so
> > guessing this might be more obscure than usual.
>
> I suspect this would be fixed with commit ce99d0bf312d ("kbuild: clear
> LDFLAGS in the top Makefile"), which backports cleanly to 4.14.
>
> Cheers,
> Nathan

Ah, yes.
Please back-port that commit. Thanks!


-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [linux-stable-rc:queue/4.14 13/175] Makefile:877: *** Recursive variable 'LDFLAGS' references itself (eventually). Stop.
  2022-08-22 19:16     ` Masahiro Yamada
@ 2022-08-23  6:47       ` Greg Kroah-Hartman
  0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2022-08-23  6:47 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: Nathan Chancellor, Nick Desaulniers, kbuild-all,
	Linux Kernel Mailing List, Sasha Levin, kernel test robot,
	Linus Torvalds

On Tue, Aug 23, 2022 at 04:16:13AM +0900, Masahiro Yamada wrote:
> On Tue, Aug 23, 2022 at 3:47 AM Nathan Chancellor <nathan@kernel.org> wrote:
> >
> > On Mon, Aug 22, 2022 at 10:05:50AM -0700, Nick Desaulniers wrote:
> > > On Sat, Aug 20, 2022 at 3:51 PM kernel test robot <lkp@intel.com> wrote:
> > > >
> > > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git queue/4.14
> > > > head:   ed8a2f4d20af62ebd64e4092d988d4ae6b54657c
> > > > commit: 17c47886b521ae64a733f41364def799797e45ef [13/175] Makefile: link with -z noexecstack --no-warn-rwx-segments
> > > > config: arc-randconfig-r043-20220821 (https://download.01.org/0day-ci/archive/20220821/202208210645.72NkUj0g-lkp@intel.com/config)
> > > > compiler: arc-elf-gcc (GCC) 7.5.0
> > > > reproduce (this is a W=1 build):
> > > >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > >         chmod +x ~/bin/make.cross
> > > >         # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=17c47886b521ae64a733f41364def799797e45ef
> > > >         git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> > > >         git fetch --no-tags linux-stable-rc queue/4.14
> > > >         git checkout 17c47886b521ae64a733f41364def799797e45ef
> > > >         # save the config file
> > > >         mkdir build_dir && cp config build_dir/.config
> > > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-7.5.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash
> > > >
> > > > If you fix the issue, kindly add following tag where applicable
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > >
> > > > All errors (new ones prefixed by >>):
> > > >
> > > > >> Makefile:877: *** Recursive variable 'LDFLAGS' references itself (eventually).  Stop.
> > >
> > > Thanks for the report!
> > >
> > > That's not something that I've seen before...
> > >
> > > Masahiro, does ARCH=arc do something special to LDFLAGS?
> > >
> > > This report is a randconfig against a branch of stable for arc, so
> > > guessing this might be more obscure than usual.
> >
> > I suspect this would be fixed with commit ce99d0bf312d ("kbuild: clear
> > LDFLAGS in the top Makefile"), which backports cleanly to 4.14.
> >
> > Cheers,
> > Nathan
> 
> Ah, yes.
> Please back-port that commit. Thanks!

Now queued up, thanks!

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-08-23  6:47 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-20 22:50 [linux-stable-rc:queue/4.14 13/175] Makefile:877: *** Recursive variable 'LDFLAGS' references itself (eventually). Stop kernel test robot
2022-08-22 17:05 ` Nick Desaulniers
2022-08-22 18:47   ` Nathan Chancellor
2022-08-22 19:16     ` Masahiro Yamada
2022-08-23  6:47       ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®