From: Peter Zijlstra <peterz@infradead.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
bhelgaas@google.com, gregkh@linuxfoundation.org
Subject: Re: [PATCH] earlyprintk: Clean up pciserial
Date: Thu, 25 Aug 2022 21:36:35 +0200 [thread overview]
Message-ID: <YwfPQ1cmzBZ2uP2o@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20220825173959.GA2856913@bhelgaas>
On Thu, Aug 25, 2022 at 12:39:59PM -0500, Bjorn Helgaas wrote:
> > - (((classcode >> 8) & 0xff) != 0x02)) /* 16550 I/F at BAR0 */ {
> > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> > index 6feade66efdb..1d2c7df8cd41 100644
> > --- a/include/linux/pci_ids.h
> > +++ b/include/linux/pci_ids.h
> > @@ -75,6 +75,9 @@
> > #define PCI_CLASS_COMMUNICATION_MODEM 0x0703
> > #define PCI_CLASS_COMMUNICATION_OTHER 0x0780
> >
> > +/* I/F for SERIAL/MODEM */
>
> I/F? Grep says it's fairly common, but doesn't seem completely
> obvious. I guess it means "interface"?
It does, I carried the nomenclature from the above line; happy to change
it if you want.
https://wiki.osdev.org/PCI#Class_Codes
Calls it 'Prog IF'.
> > +#define PCI_SERIAL_16550_COMPATIBLE 0x02
> > +
> > #define PCI_BASE_CLASS_SYSTEM 0x08
> > #define PCI_CLASS_SYSTEM_PIC 0x0800
> > #define PCI_CLASS_SYSTEM_PIC_IOAPIC 0x080010
next prev parent reply other threads:[~2022-08-25 19:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 11:36 Peter Zijlstra
2022-08-25 11:48 ` Greg KH
2022-08-25 17:39 ` Bjorn Helgaas
2022-08-25 19:36 ` Peter Zijlstra [this message]
2022-08-25 19:51 ` Bjorn Helgaas
2022-08-25 20:08 ` Peter Zijlstra
2022-08-29 10:52 ` [tip: x86/core] x86/earlyprintk: " tip-bot2 for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwfPQ1cmzBZ2uP2o@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®