From: Herbert Xu <herbert@gondor.apana.org.au>
To: cuigaosheng <cuigaosheng1@huawei.com>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next 1/2] crypto: api - Fix IS_ERR() vs NULL check
Date: Fri, 2 Sep 2022 18:25:45 +0800 [thread overview]
Message-ID: <YxHaKSOedCC9DLX1@gondor.apana.org.au> (raw)
In-Reply-To: <0ae57826-6a8c-b08b-2889-f91d50bf6e59@huawei.com>
On Thu, Aug 25, 2022 at 09:10:49PM +0800, cuigaosheng wrote:
> Thanks for taking the time to review this patch.
>
> crypto_alloc_test_larval() will return null if manager is disabled,
> it will not return error pointers, IS_ERR should not be used to checking
> return value, should we fix it? or use another solution?
That's because NULL is returned indicating success. When a genuine
error occurs then an error pointer will be returned. IS_ERR will be
true only in case of a genuine error. It will be false when either
NULL or a real larval pointer is returned.
You need to describe your problem more clearly as I have no idea what
you're trying to fix.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2022-09-02 10:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 8:41 [PATCH -next 0/2] A few fixup patches for crypto Gaosheng Cui
2022-08-25 8:41 ` [PATCH -next 1/2] crypto: api - Fix IS_ERR() vs NULL check Gaosheng Cui
2022-08-25 8:50 ` Herbert Xu
2022-08-25 13:10 ` cuigaosheng
2022-09-02 10:25 ` Herbert Xu [this message]
2022-08-25 8:41 ` [PATCH -next 2/2] crypto: crc32c - add missing Kconfig option select Gaosheng Cui
2022-08-25 8:50 ` Herbert Xu
2022-08-25 12:55 ` cuigaosheng
2022-09-02 10:23 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxHaKSOedCC9DLX1@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=cuigaosheng1@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®