From: Herbert Xu <herbert@gondor.apana.org.au>
To: Gaosheng Cui <cuigaosheng1@huawei.com>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next 2/2] crypto: crc32c - add missing Kconfig option select
Date: Thu, 25 Aug 2022 16:50:48 +0800 [thread overview]
Message-ID: <Ywc36LxM2+0eqKu2@gondor.apana.org.au> (raw)
In-Reply-To: <20220825084138.1881954-3-cuigaosheng1@huawei.com>
On Thu, Aug 25, 2022 at 04:41:38PM +0800, Gaosheng Cui wrote:
> The CRYPTO_CRC32C is using functions provided by CRYPTO_MANAGER,
> otherwise the following error will occur:
>
> EXT4-fs (mmcblk0): Cannot load crc32c driver.
>
> So select CRYPTO_MANAGER when enable CRYPTO_CRC32C.
>
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
> crypto/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index b1ccf873779d..7f124604323b 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -641,6 +641,7 @@ config CRYPTO_CRC32C
> tristate "CRC32c CRC algorithm"
> select CRYPTO_HASH
> select CRC32
> + select CRYPTO_MANAGER
> help
> Castagnoli, et al Cyclic Redundancy-Check Algorithm. Used
> by iSCSI for header and data digests and by others.
Why exactly does it need CRYPTO_MANAGER?
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2022-08-25 8:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 8:41 [PATCH -next 0/2] A few fixup patches for crypto Gaosheng Cui
2022-08-25 8:41 ` [PATCH -next 1/2] crypto: api - Fix IS_ERR() vs NULL check Gaosheng Cui
2022-08-25 8:50 ` Herbert Xu
2022-08-25 13:10 ` cuigaosheng
2022-09-02 10:25 ` Herbert Xu
2022-08-25 8:41 ` [PATCH -next 2/2] crypto: crc32c - add missing Kconfig option select Gaosheng Cui
2022-08-25 8:50 ` Herbert Xu [this message]
2022-08-25 12:55 ` cuigaosheng
2022-09-02 10:23 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ywc36LxM2+0eqKu2@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=cuigaosheng1@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®