From: Andrew Lunn <andrew@lunn.ch>
To: Jerry.Ray@microchip.com
Cc: vivien.didelot@gmail.com, f.fainelli@gmail.com,
olteanv@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] net: dsa: LAN9303: Add basic support for LAN9354
Date: Fri, 2 Sep 2022 22:29:55 +0200 [thread overview]
Message-ID: <YxJnw40yGUFGYopB@lunn.ch> (raw)
In-Reply-To: <MWHPR11MB16938C27CC03D84BA2194DC3EF7A9@MWHPR11MB1693.namprd11.prod.outlook.com>
> >Please validate that what you find on the board actually is what the compatible says it should be. If you don't validate it, there will be some DT blobs that have the wrong value, but probe fine. But then you cannot actually make use of the compatible string in the driver to do something different between the 9303 and the 9354 because some boards have the wrong compatible....
Please configure your mail client to stop corrupting emails. My reply
definitely did not have lines this long.
> >
> > Andrew
> >
>
> At this time, the driver is meant to support both devices equally. In the future, I will be adding content that only applies to the LAN9354. That is when I'm planning to add .data to the .compatible entries.
Which makes it even more important to validate the compatible against
what is actually on the board. As i said, in its current state, people
are going to get it wrong, and your .data won't work, since it will be
for a different chip to which is actually on the board.
Andrew
next prev parent reply other threads:[~2022-09-02 20:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 18:00 [PATCH 1/2] " Jerry Ray
2022-08-29 18:00 ` [PATCH 2/2] " Jerry Ray
2022-08-29 19:20 ` Andrew Lunn
2022-09-02 20:18 ` Jerry.Ray
2022-09-02 20:29 ` Andrew Lunn [this message]
2022-08-29 19:22 ` Andrew Lunn
2022-09-02 20:24 ` Jerry.Ray
2022-08-30 10:33 ` [PATCH 1/2] " Vladimir Oltean
2022-09-02 20:10 ` Jerry.Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxJnw40yGUFGYopB@lunn.ch \
--to=andrew@lunn.ch \
--cc=Jerry.Ray@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®