mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Kumaravel.Thiagarajan@microchip.com
Cc: lkp@intel.com, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: [char-misc:char-misc-next 21/24] drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:135:34: sparse: sparse: symbol 'pci1xxxx_gpio_auxiliary_id_table' was not declared. Should it be static?
Date: Wed, 7 Sep 2022 08:08:08 +0200	[thread overview]
Message-ID: <Yxg1SADGQaJ6jGiY@kroah.com> (raw)
In-Reply-To: <BN8PR11MB3668B1EAD67AFB7CB5CCB6C2E97E9@BN8PR11MB3668.namprd11.prod.outlook.com>

On Tue, Sep 06, 2022 at 06:02:22PM +0000, Kumaravel.Thiagarajan@microchip.com wrote:
> > -----Original Message-----
> > From: kernel test robot <lkp@intel.com>
> > Sent: Monday, September 5, 2022 12:07 PM
> > To: Kumaravel Thiagarajan - I21417 <Kumaravel.Thiagarajan@microchip.com>
> > Cc: kbuild-all@lists.01.org; linux-kernel@vger.kernel.org; Greg Kroah-
> > Hartman <gregkh@linuxfoundation.org>
> > Subject: [char-misc:char-misc-next 21/24]
> > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:135:34: sparse: sparse:
> > symbol 'pci1xxxx_gpio_auxiliary_id_table' was not declared. Should it be
> > static?
> > 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
> > char-misc-next
> > head:   50e177c5bfd9abc3828cb57e14e6169170f6764a
> > commit: 7d3e4d807df2a216b9aa2944372f2b3f6ef3f205 [21/24] misc:
> > microchip: pci1xxxx: load gpio driver for the gpio controller auxiliary device
> > enumerated by the auxiliary bus driver.
> > config: i386-randconfig-s033-20220905
> > compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
> .
> .
> .
> > 
> > sparse warnings: (new ones prefixed by >>)
> > >> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:135:34: sparse:
> > sparse: symbol 'pci1xxxx_gpio_auxiliary_id_table' was not declared. Should it
> > be static?
> Greg, do I need to submit another patch to resolve this warning on char-misc-next?
> I did not combine this with the last patch thinking that the last patch would
> be merged with the commit that introduced the errors and not queued.

No, I can't merge it into an older commit as those branches can never be
rebased.

Please send a new fix for this issue as well.

thanks,

greg k-h

      reply	other threads:[~2022-09-07  6:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-05  6:36 kernel test robot
2022-09-06 18:02 ` Kumaravel.Thiagarajan
2022-09-07  6:08   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yxg1SADGQaJ6jGiY@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Kumaravel.Thiagarajan@microchip.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®