mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Magnus Damm <damm+renesas@opensource.se>,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v2 1/1] serdev: Replace poll loop by readx_poll_timeout() macro
Date: Sat, 24 Sep 2022 13:57:29 +0200	[thread overview]
Message-ID: <Yy7wqSWVBGwNtiiZ@kroah.com> (raw)
In-Reply-To: <20220923171048.37386-1-andriy.shevchenko@linux.intel.com>

On Fri, Sep 23, 2022 at 08:10:48PM +0300, Andy Shevchenko wrote:
> The readx_poll_timeout() consolidates the necessary code under
> macro. Replace current code with it.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v2: dropped TODO: in the Subject line
>  include/linux/serdev.h | 14 ++++----------
>  1 file changed, 4 insertions(+), 10 deletions(-)
> 
> diff --git a/include/linux/serdev.h b/include/linux/serdev.h
> index 66f624fc618c..69d9c3188065 100644
> --- a/include/linux/serdev.h
> +++ b/include/linux/serdev.h
> @@ -7,9 +7,11 @@
>  
>  #include <linux/types.h>
>  #include <linux/device.h>
> +#include <linux/iopoll.h>
>  #include <linux/uaccess.h>
>  #include <linux/termios.h>
>  #include <linux/delay.h>
> +#include <vdso/time64.h>

Ick, just for USEC_PER_MSEC?  That should be in units.h, not burried in
a vdso-only .h file.  This feels wrong, sorry.

greg k-h

  reply	other threads:[~2022-09-24 11:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-23 17:10 Andy Shevchenko
2022-09-24 11:57 ` Greg Kroah-Hartman [this message]
2022-09-26 10:48   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yy7wqSWVBGwNtiiZ@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=damm+renesas@opensource.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome