From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Magnus Damm <damm+renesas@opensource.se>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v2 1/1] serdev: Replace poll loop by readx_poll_timeout() macro
Date: Mon, 26 Sep 2022 13:48:48 +0300 [thread overview]
Message-ID: <YzGDkKnttYBI4S0Q@smile.fi.intel.com> (raw)
In-Reply-To: <Yy7wqSWVBGwNtiiZ@kroah.com>
On Sat, Sep 24, 2022 at 01:57:29PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Sep 23, 2022 at 08:10:48PM +0300, Andy Shevchenko wrote:
> > The readx_poll_timeout() consolidates the necessary code under
> > macro. Replace current code with it.
...
> > +#include <vdso/time64.h>
>
> Ick, just for USEC_PER_MSEC? That should be in units.h, not burried in
> a vdso-only .h file. This feels wrong, sorry.
Why are you asking me about this? It was not my choice and it was made
a couple of years ago (see [1]).
As a solution I can just drop using that constant in v3.
[1]: b72a9c5e023b ("linux/time64.h: Extract common header for vDSO")
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-09-26 11:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 17:10 Andy Shevchenko
2022-09-24 11:57 ` Greg Kroah-Hartman
2022-09-26 10:48 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzGDkKnttYBI4S0Q@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=damm+renesas@opensource.se \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome