* [PATCH] media: i2c: ov5645: Drop fetching the clk reference by name
@ 2022-09-19 14:33 Prabhakar
2022-09-19 14:42 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Prabhakar @ 2022-09-19 14:33 UTC (permalink / raw)
To: Laurent Pinchart, Mauro Carvalho Chehab, Sakari Ailus, Jacopo Mondi
Cc: linux-media, linux-kernel, Prabhakar, Lad Prabhakar
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
The OV5645 sensor has a single clock source, so just drop fetching the
clk reference by name.
This is in preparation to drop the "clock-names" property from the DT
binding.
Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
drivers/media/i2c/ov5645.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c
index 81e4e87e1821..47451238ca05 100644
--- a/drivers/media/i2c/ov5645.c
+++ b/drivers/media/i2c/ov5645.c
@@ -1090,7 +1090,7 @@ static int ov5645_probe(struct i2c_client *client)
}
/* get system clock (xclk) */
- ov5645->xclk = devm_clk_get(dev, "xclk");
+ ov5645->xclk = devm_clk_get(dev, NULL);
if (IS_ERR(ov5645->xclk)) {
dev_err(dev, "could not get xclk");
return PTR_ERR(ov5645->xclk);
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] media: i2c: ov5645: Drop fetching the clk reference by name
2022-09-19 14:33 [PATCH] media: i2c: ov5645: Drop fetching the clk reference by name Prabhakar
@ 2022-09-19 14:42 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2022-09-19 14:42 UTC (permalink / raw)
To: Prabhakar
Cc: Mauro Carvalho Chehab, Sakari Ailus, Jacopo Mondi, linux-media,
linux-kernel, Lad Prabhakar
Hi Prabhakar,
Thank you for the patch.
On Mon, Sep 19, 2022 at 03:33:50PM +0100, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> The OV5645 sensor has a single clock source, so just drop fetching the
> clk reference by name.
>
> This is in preparation to drop the "clock-names" property from the DT
> binding.
>
> Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/media/i2c/ov5645.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c
> index 81e4e87e1821..47451238ca05 100644
> --- a/drivers/media/i2c/ov5645.c
> +++ b/drivers/media/i2c/ov5645.c
> @@ -1090,7 +1090,7 @@ static int ov5645_probe(struct i2c_client *client)
> }
>
> /* get system clock (xclk) */
> - ov5645->xclk = devm_clk_get(dev, "xclk");
> + ov5645->xclk = devm_clk_get(dev, NULL);
> if (IS_ERR(ov5645->xclk)) {
> dev_err(dev, "could not get xclk");
> return PTR_ERR(ov5645->xclk);
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-19 14:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-19 14:33 [PATCH] media: i2c: ov5645: Drop fetching the clk reference by name Prabhakar
2022-09-19 14:42 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®