From: Peter Zijlstra <peterz@infradead.org>
To: Waiman Long <longman@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Valentin Schneider <vschneid@redhat.com>,
Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Lai Jiangshan <jiangshanlai@gmail.com>
Subject: Re: [PATCH v9 0/7] sched: Persistent user requested affinity
Date: Thu, 22 Sep 2022 10:45:31 +0200 [thread overview]
Message-ID: <Yywgq+NUZH+JuJpF@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20220916183217.1172225-1-longman@redhat.com>
On Fri, Sep 16, 2022 at 02:32:10PM -0400, Waiman Long wrote:
> Waiman Long (7):
> sched: Add __releases annotations to affine_move_task()
> sched: Use user_cpus_ptr for saving user provided cpumask in
> sched_setaffinity()
> sched: Enforce user requested affinity
> sched: Introduce affinity_context structure
> sched: Handle set_cpus_allowed_ptr() & sched_setaffinity() race
> sched: Fix sched_setaffinity() and fork/clone() race
> sched: Always clear user_cpus_ptr in do_set_cpus_allowed()
I still think this is ordered all wrong. Esp. with that affinity context
doing the right thing isn't onerous at all.
So please, re-order this and fold all fixes back in so that it becomes
a sane series. Basically patches 5 and 6 shouldn't exist, they fix
issues created by the earlier patches.
next prev parent reply other threads:[~2022-09-22 8:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 18:32 Waiman Long
2022-09-16 18:32 ` [PATCH v9 1/7] sched: Add __releases annotations to affine_move_task() Waiman Long
2022-09-16 18:32 ` [PATCH v9 2/7] sched: Use user_cpus_ptr for saving user provided cpumask in sched_setaffinity() Waiman Long
2022-09-26 2:51 ` [sched] 3cf68f7aae: WARNING:at_kernel/rcu/update.c:#rcutorture_sched_setaffinity kernel test robot
2022-10-07 18:09 ` Waiman Long
2022-09-16 18:32 ` [PATCH v9 3/7] sched: Enforce user requested affinity Waiman Long
2022-09-16 18:32 ` [PATCH v9 4/7] sched: Introduce affinity_context structure Waiman Long
2022-09-16 18:32 ` [PATCH v9 5/7] sched: Handle set_cpus_allowed_ptr() & sched_setaffinity() race Waiman Long
2022-09-16 18:32 ` [PATCH v9 6/7] sched: Fix sched_setaffinity() and fork/clone() race Waiman Long
2022-09-16 18:32 ` [PATCH v9 7/7] sched: Always clear user_cpus_ptr in do_set_cpus_allowed() Waiman Long
2022-09-22 8:45 ` Peter Zijlstra [this message]
2022-09-22 11:56 ` [PATCH v9 0/7] sched: Persistent user requested affinity Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yywgq+NUZH+JuJpF@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=hannes@cmpxchg.org \
--cc=jiangshanlai@gmail.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®