From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Mikhail Rudenko <mike.rudenko@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Jacopo Mondi <jacopo@jmondi.org>, Shawn Tu <shawnx.tu@intel.com>,
Randy Dunlap <rdunlap@infradead.org>,
Daniel Scally <djrscally@gmail.com>,
Christian Hemp <c.hemp@phytec.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Marek Vasut <marex@denx.de>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] media: i2c: add support for ov4689
Date: Thu, 22 Sep 2022 20:39:48 +0000 [thread overview]
Message-ID: <YyzIFGo6SYhVP6sj@paasikivi.fi.intel.com> (raw)
In-Reply-To: <87czbnif04.fsf@gmail.com>
Hi Mikhail,
On Thu, Sep 22, 2022 at 06:23:05PM +0300, Mikhail Rudenko wrote:
>
> Hi Sakari,
>
> and thanks for reviewing this!
You're welcome!
>
> Please see my comments below:
>
> On 2022-09-22 at 09:53 GMT, Sakari Ailus <sakari.ailus@linux.intel.com> wrote:
...
> >> +static inline u32 ov4689_cal_delay(u32 cycles)
> >> +{
> >> + return DIV_ROUND_UP(cycles, OV4689_XVCLK_FREQ / 1000 / 1000);
> >
> > Please use the actual rate instead.
> >
>
> Do you mean clk_get_rate(ov4689->xvclk), right? What if we have an ACPI
Yes.
> system and xvclk is NULL here? Please explain.
There are a few ways this could work on ACPI based systems but generally
you'd have "clock-frequency" property to indicate the frequency even if
clocks themselves wouldn't be available (when controlled via ACPI)).
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2022-09-22 20:40 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 20:01 [PATCH v2 0/2] Add Omnivision OV4689 image sensor driver Mikhail Rudenko
2022-09-11 20:01 ` [PATCH v2 1/2] media: dt-bindings: media: i2c: document OV4689 DT bindings Mikhail Rudenko
2022-09-12 10:55 ` Krzysztof Kozlowski
2022-09-15 12:16 ` Mikhail Rudenko
2022-09-16 9:42 ` Krzysztof Kozlowski
2022-09-13 14:05 ` Tommaso Merciai
2022-09-15 20:11 ` Mikhail Rudenko
2022-09-16 13:15 ` Tommaso Merciai
2022-09-16 13:42 ` Mikhail Rudenko
2022-09-19 13:16 ` Laurent Pinchart
2022-09-11 20:01 ` [PATCH v2 2/2] media: i2c: add support for ov4689 Mikhail Rudenko
2022-09-11 22:52 ` kernel test robot
2022-09-12 10:56 ` Krzysztof Kozlowski
2022-09-15 20:40 ` Mikhail Rudenko
2022-09-16 9:43 ` Krzysztof Kozlowski
2022-09-16 21:51 ` Sakari Ailus
2022-09-14 15:51 ` Tommaso Merciai
2022-09-15 20:50 ` Mikhail Rudenko
2022-09-16 13:34 ` Tommaso Merciai
2022-09-16 13:44 ` Mikhail Rudenko
2022-09-19 7:08 ` Tommaso Merciai
2022-09-19 6:33 ` Sakari Ailus
2022-09-19 7:11 ` Tommaso Merciai
2022-09-22 9:53 ` Sakari Ailus
2022-09-22 15:23 ` Mikhail Rudenko
2022-09-22 20:39 ` Sakari Ailus [this message]
2022-09-22 10:54 ` Dave Stevenson
2022-09-22 14:56 ` Mikhail Rudenko
2022-09-14 9:58 ` [PATCH v2 0/2] Add Omnivision OV4689 image sensor driver Dave Stevenson
2022-09-15 21:27 ` Mikhail Rudenko
2022-09-19 6:40 ` Sakari Ailus
2022-09-19 7:01 ` Mikhail Rudenko
2022-09-19 10:31 ` Sakari Ailus
2022-09-19 13:49 ` Laurent Pinchart
2022-09-20 15:55 ` Mikhail Rudenko
2022-09-20 20:31 ` Mikhail Rudenko
2022-09-21 13:16 ` Sakari Ailus
2022-09-22 9:53 ` Sakari Ailus
2022-09-22 10:43 ` Dave Stevenson
2022-09-22 15:13 ` Mikhail Rudenko
2022-09-26 10:47 ` Mikhail Rudenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyzIFGo6SYhVP6sj@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=c.hemp@phytec.de \
--cc=devicetree@vger.kernel.org \
--cc=djrscally@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo@jmondi.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=marex@denx.de \
--cc=mchehab@kernel.org \
--cc=mike.rudenko@gmail.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=shawnx.tu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®