From: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
kw@linux.com, bhelgaas@google.com, linux-pci@vger.kernel.org,
robh@kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] PCI: qcom-ep: Fix disabling global_irq in error path
Date: Thu, 6 Oct 2022 08:35:34 +0200 [thread overview]
Message-ID: <Yz53NnxEkS7hg8Vc@lpieralisi> (raw)
In-Reply-To: <20221005173529.GA2304247@bhelgaas>
On Wed, Oct 05, 2022 at 12:35:29PM -0500, Bjorn Helgaas wrote:
> On Wed, Oct 05, 2022 at 07:28:52PM +0530, Manivannan Sadhasivam wrote:
> > After commit 6a534df3da88 ("PCI: qcom-ep: Disable IRQs during driver
> > remove"), the global irq is stored in the "global_irq" member of pcie_ep
> > structure. This eliminates the need of local "irq" variable but that
> > commit didn't remove the "irq" variable usage completely and it is still
> > used for disable_irq() in error path which is wrong since the variable is
> > uninitialized.
> >
> > Fix this by removing the local "irq" variable and using
> > "pcie_ep->global_irq" for disable_irq() in error path.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Fixes: 6a534df3da88 ("PCI: qcom-ep: Disable IRQs during driver remove")
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
> For today's "next" branch, I dropped 6a534df3da88 and the subsequent
> patches. Hopefully Lorenzo can squash this fix into 6a534df3da88.
Done - the pci/qcom branch successfully passed kbot's tests as well.
Lorenzo
next prev parent reply other threads:[~2022-10-06 6:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 13:58 Manivannan Sadhasivam
2022-10-05 17:35 ` Bjorn Helgaas
2022-10-06 6:35 ` Lorenzo Pieralisi [this message]
2022-10-06 16:07 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz53NnxEkS7hg8Vc@lpieralisi \
--to=lpieralisi@kernel.org \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lkp@intel.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®