From: Peter Zijlstra <peterz@infradead.org>
To: Jim Mattson <jmattson@google.com>
Cc: Suraj Jitindar Singh <surajjs@amazon.com>,
kvm@vger.kernel.org, sjitindarsingh@gmail.com,
linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de,
mingo@redhat.com, bp@suse.de, dave.hansen@linux.intel.com,
seanjc@google.com, pbonzini@redhat.com, jpoimboe@kernel.org,
daniel.sneddon@linux.intel.com,
pawan.kumar.gupta@linux.intel.com, benh@kernel.crashing.org,
stable@vger.kernel.org
Subject: Re: [PATCH] x86/speculation: Mitigate eIBRS PBRSB predictions with WRMSR
Date: Thu, 6 Oct 2022 10:18:24 +0200 [thread overview]
Message-ID: <Yz6PUJqThY9NPHRs@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CALMp9eThzv+5UBPtm77nvD_b48hHD7O1QLni7a+x9zAPicFk4Q@mail.gmail.com>
On Wed, Oct 05, 2022 at 04:46:12PM -0700, Jim Mattson wrote:
> rmb();
Since we're not doing memory ordering but speculation hardening, this is
completely the wrong way to spell LFENCE. Please use barrier_nospec() in
those cases.
And as has already been pointed out, there's one of those just two lines
down already.
Also, what Andrew said.
next prev parent reply other threads:[~2022-10-06 8:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 22:02 Suraj Jitindar Singh
2022-10-05 22:29 ` Jim Mattson
2022-10-06 8:25 ` David Laight
2022-10-06 20:27 ` pawan.kumar.gupta
2022-10-05 23:24 ` Jim Mattson
2022-10-05 23:45 ` Pawan Gupta
2022-10-05 23:46 ` Jim Mattson
2022-10-06 0:26 ` Daniel Sneddon
2022-10-06 1:28 ` Jim Mattson
2022-10-06 8:18 ` Peter Zijlstra [this message]
2022-10-06 2:42 ` Andrew Cooper
2022-10-07 1:44 ` pawan.kumar.gupta
2022-10-07 1:54 ` Pawan Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz6PUJqThY9NPHRs@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=benh@kernel.crashing.org \
--cc=bp@suse.de \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jmattson@google.com \
--cc=jpoimboe@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=sjitindarsingh@gmail.com \
--cc=stable@vger.kernel.org \
--cc=surajjs@amazon.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®