mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Akihiko Odaki <akihiko.odaki@gmail.com>
Cc: "Liam Girdwood" <lgirdwood@gmail.com>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	"Nícolas F . R . A . Prado" <nfraprado@collabora.com>
Subject: Re: [PATCH 1/2] ASoC: amd: acp3x-5682: Remove SND_JACK_LINEOUT
Date: Mon, 26 Sep 2022 14:27:04 +0100	[thread overview]
Message-ID: <YzGoqEFunlmj+kAn@sirena.org.uk> (raw)
In-Reply-To: <20220924095025.7778-1-akihiko.odaki@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

On Sat, Sep 24, 2022 at 06:50:24PM +0900, Akihiko Odaki wrote:

> RT5682 only has a headset jack.

>  	ret = snd_soc_card_jack_new(card, "Headset Jack",
> -				SND_JACK_HEADSET | SND_JACK_LINEOUT |
> +				SND_JACK_HEADSET |

Will the device by any chance happily drive this as a line output
(possibly even detect if it's a headphone or a line output device
attached)?  The CODEC hardware is often interchangable.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      parent reply	other threads:[~2022-09-26 14:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-24  9:50 Akihiko Odaki
2022-09-24  9:50 ` [PATCH 2/2] ASoC: amd: acp3x-5682: Expose individual headset jack pins Akihiko Odaki
2022-09-26 13:27 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YzGoqEFunlmj+kAn@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=akihiko.odaki@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nfraprado@collabora.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®