* [PATCH 2/2] ASoC: amd: acp3x-5682: Expose individual headset jack pins
2022-09-24 9:50 [PATCH 1/2] ASoC: amd: acp3x-5682: Remove SND_JACK_LINEOUT Akihiko Odaki
@ 2022-09-24 9:50 ` Akihiko Odaki
2022-09-26 13:27 ` [PATCH 1/2] ASoC: amd: acp3x-5682: Remove SND_JACK_LINEOUT Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Akihiko Odaki @ 2022-09-24 9:50 UTC (permalink / raw)
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Matthias Brugger, alsa-devel, linux-kernel,
Nícolas F . R . A . Prado, Akihiko Odaki
The rt5682 codec is able to distinguish between two event types:
headphone insertion/removal and headset microphone insertion/removal.
However, currently, the acp3x-5682 driver exposes a single kcontrol
for the headset jack, so userspace isn't able to differentiate between
the two events.
Add a definition for the headset jack pins, so that a separate jack
kcontrol is created for each one, allowing userspace to track and handle
them individually.
This change is based on commit 194ff8db0378 ("ASoC: mediatek:
mt8192-mt6359: Expose individual headset jack pins").
Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
---
sound/soc/amd/acp3x-rt5682-max9836.c | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/sound/soc/amd/acp3x-rt5682-max9836.c b/sound/soc/amd/acp3x-rt5682-max9836.c
index 0bdd9c26dd22..3679931a2285 100644
--- a/sound/soc/amd/acp3x-rt5682-max9836.c
+++ b/sound/soc/amd/acp3x-rt5682-max9836.c
@@ -39,6 +39,17 @@ enum {
EC,
};
+static struct snd_soc_jack_pin acp3x_5682_jack_pins[] = {
+ {
+ .pin = "Headphone Jack",
+ .mask = SND_JACK_HEADPHONE,
+ },
+ {
+ .pin = "Headset Mic",
+ .mask = SND_JACK_MICROPHONE,
+ },
+};
+
static int acp3x_5682_init(struct snd_soc_pcm_runtime *rtd)
{
int ret;
@@ -86,11 +97,12 @@ static int acp3x_5682_init(struct snd_soc_pcm_runtime *rtd)
rt5682_dai_wclk = clk_get(component->dev, "rt5682-dai-wclk");
rt5682_dai_bclk = clk_get(component->dev, "rt5682-dai-bclk");
- ret = snd_soc_card_jack_new(card, "Headset Jack",
+ ret = snd_soc_card_jack_new_pins(card, "Headset Jack",
SND_JACK_HEADSET |
SND_JACK_BTN_0 | SND_JACK_BTN_1 |
SND_JACK_BTN_2 | SND_JACK_BTN_3,
- &pco_jack);
+ &pco_jack, acp3x_5682_jack_pins,
+ ARRAY_SIZE(acp3x_5682_jack_pins));
if (ret) {
dev_err(card->dev, "HP jack creation failed %d\n", ret);
return ret;
--
2.37.3
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] ASoC: amd: acp3x-5682: Remove SND_JACK_LINEOUT
2022-09-24 9:50 [PATCH 1/2] ASoC: amd: acp3x-5682: Remove SND_JACK_LINEOUT Akihiko Odaki
2022-09-24 9:50 ` [PATCH 2/2] ASoC: amd: acp3x-5682: Expose individual headset jack pins Akihiko Odaki
@ 2022-09-26 13:27 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2022-09-26 13:27 UTC (permalink / raw)
To: Akihiko Odaki
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Matthias Brugger,
alsa-devel, linux-kernel, Nícolas F . R . A . Prado
[-- Attachment #1: Type: text/plain, Size: 413 bytes --]
On Sat, Sep 24, 2022 at 06:50:24PM +0900, Akihiko Odaki wrote:
> RT5682 only has a headset jack.
> ret = snd_soc_card_jack_new(card, "Headset Jack",
> - SND_JACK_HEADSET | SND_JACK_LINEOUT |
> + SND_JACK_HEADSET |
Will the device by any chance happily drive this as a line output
(possibly even detect if it's a headphone or a line output device
attached)? The CODEC hardware is often interchangable.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread