mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yury Norov <yury.norov@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [GIT PULL] bitmap changes for v6.0-rc1
Date: Tue, 4 Oct 2022 11:16:29 -0700	[thread overview]
Message-ID: <Yzx4fSmmr8bh6gdl@yury-laptop> (raw)
In-Reply-To: <CAHk-=wjBRtxcTQ0UXUWKFYWbz-vc8wCFZYV7UuJegH4nQot_UA@mail.gmail.com>

On Tue, Oct 04, 2022 at 10:55:51AM -0700, Linus Torvalds wrote:
> On Sun, Oct 2, 2022 at 7:03 PM Yury Norov <yury.norov@gmail.com> wrote:
> >
> > Please pull this patches. They spent more than a week in -next without
> > major problems. The only problem with warnings generated by cpumask_check(),
> > when robots do bisection, is fixed by moving the patch "cpumask: fix
> > checking valid cpu range" to the very end of the series.
> 
> So I appreciate the commentary about process just to explain what's going on.
> 
> But what I want for the merge message is a summary of what the pull
> actually *does* - the process commentary is good addition, but it's
> not useful for the merge commit message about what the merge actually
> brings in.
> 
> And for that, I do *not* want explanations like this:
> 
> > This branch is based on v6.0-rc4 and includes:
> >
> > drivers/base: Fix unsigned comparison to -1 in CPUMAP_FILE_MAX_BYTES
> > From Phil Auld
> > https://lore.kernel.org/lkml/20220906203542.1796629-1-pauld@redhat.com/
> ...
> 
> where the explanations just point to external data.
> 
> Commit messages are supposed to be self-sufficient. External links can
> be acceptable as a "this has subtle issues that are too boring and
> extensive to explain here", but even then it's only for _additional_
> commentary, not a replacement for explaining what is going on.
> 
> And those external links aren't even that. They are literally just the
> "this is where the patches were posted originally". Not useful.
> 
> So I'm dropping this as not having enough explanations of why I should
> pull them. It has explanations, yes, but they are about secondary
> things, not about the actual expected improvements brought in by the
> pull.

OK, I'll resend shortly

Thanks,
Yury

  reply	other threads:[~2022-10-04 18:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-03  2:03 Yury Norov
2022-10-04 17:55 ` Linus Torvalds
2022-10-04 18:16   ` Yury Norov [this message]
2022-10-10 20:05 ` pr-tracker-bot
2022-10-10 21:12 ` Linus Torvalds
2022-10-10 21:18   ` Linus Torvalds
2022-10-11  3:07     ` Yury Norov
2022-10-11  3:19       ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yzx4fSmmr8bh6gdl@yury-laptop \
    --to=yury.norov@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®