From: Jason Gunthorpe <jgg@ziepe.ca>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Sumit Garg <sumit.garg@kernel.org>,
Stefano Garzarella <sgarzare@redhat.com>,
linux-kernel@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
linux-integrity@vger.kernel.org,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Jens Wiklander <jens.wiklander@linaro.org>
Subject: Re: [PATCH 2/2] tpm/tpm_ftpm_tee: use send_recv() op
Date: Wed, 26 Mar 2025 11:34:01 -0300 [thread overview]
Message-ID: <Z+QQWe/upJuVpU8r@ziepe.ca> (raw)
In-Reply-To: <Z-Pu4FhcntnKii61@kernel.org>
On Wed, Mar 26, 2025 at 02:11:12PM +0200, Jarkko Sakkinen wrote:
> Generally speaking I don't see enough value in complicating
> callback interface. It's better to handle complications in
> the leaves (i.e. dictatorship of majority ;-) ).
That is very much not the way most driver subsystems view the
world. We want to pull logical things into the core code and remove
them from drivers to make the drivers simpler and more robust.
The amount of really dumb driver boiler plate that this series
obviously removes is exactly the sort of stuff we should be fixing by
improving the core code.
The callback interface was never really sanely designed, it was just
built around the idea of pulling the timout processing into the core
code for TIS hardware. It should be revised to properly match these
new HW types that don't have this kind of timeout mechanism.
Jason
next prev parent reply other threads:[~2025-03-26 14:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 15:24 [PATCH 0/2] tpm: add send_recv() op and use it in tpm_ftpm_tee driver Stefano Garzarella
2025-03-20 15:24 ` [PATCH 1/2] tpm: add send_recv() op in tpm_class_ops Stefano Garzarella
2025-03-26 16:53 ` Jarkko Sakkinen
2025-03-27 9:48 ` Stefano Garzarella
2025-03-27 13:02 ` Jarkko Sakkinen
2025-03-27 14:44 ` Stefano Garzarella
2025-03-20 15:24 ` [PATCH 2/2] tpm/tpm_ftpm_tee: use send_recv() op Stefano Garzarella
2025-03-25 5:19 ` Sumit Garg
2025-03-26 12:11 ` Jarkko Sakkinen
2025-03-26 14:34 ` Jason Gunthorpe [this message]
2025-03-26 14:57 ` Jarkko Sakkinen
2025-03-26 15:58 ` Jarkko Sakkinen
2025-03-26 20:37 ` Jarkko Sakkinen
2025-03-27 9:27 ` Stefano Garzarella
2025-03-27 13:04 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z+QQWe/upJuVpU8r@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=James.Bottomley@hansenpartnership.com \
--cc=jarkko@kernel.org \
--cc=jens.wiklander@linaro.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=sgarzare@redhat.com \
--cc=sumit.garg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®