* [PATCH] mmc: core: Drop the MMC_RSP_R1_NO_CRC response
@ 2024-11-25 13:23 Ulf Hansson
2024-11-25 16:04 ` Wolfram Sang
2024-11-26 7:50 ` Avri Altman
0 siblings, 2 replies; 3+ messages in thread
From: Ulf Hansson @ 2024-11-25 13:23 UTC (permalink / raw)
To: linux-mmc, Ulf Hansson
Cc: Adrian Hunter, Andy-ld Lu, Wolfram Sang, linux-kernel
The MMC_RSP_R1_NO_CRC type of response is not being used by the mmc core
for any commands. Let's therefore drop it, together with the corresponding
code in the host drivers.
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
drivers/mmc/host/rtsx_pci_sdmmc.c | 2 --
drivers/mmc/host/rtsx_usb_sdmmc.c | 3 ---
drivers/mmc/host/tmio_mmc_core.c | 1 -
include/linux/mmc/core.h | 3 ---
4 files changed, 9 deletions(-)
diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/rtsx_pci_sdmmc.c
index 48d3b0aae5a0..0c6eb60a95fd 100644
--- a/drivers/mmc/host/rtsx_pci_sdmmc.c
+++ b/drivers/mmc/host/rtsx_pci_sdmmc.c
@@ -115,8 +115,6 @@ static int sd_response_type(struct mmc_command *cmd)
return SD_RSP_TYPE_R0;
case MMC_RSP_R1:
return SD_RSP_TYPE_R1;
- case MMC_RSP_R1_NO_CRC:
- return SD_RSP_TYPE_R1 | SD_NO_CHECK_CRC7;
case MMC_RSP_R1B:
return SD_RSP_TYPE_R1b;
case MMC_RSP_R2:
diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_sdmmc.c
index 107c78df53cf..d229c2b83ea9 100644
--- a/drivers/mmc/host/rtsx_usb_sdmmc.c
+++ b/drivers/mmc/host/rtsx_usb_sdmmc.c
@@ -313,9 +313,6 @@ static void sd_send_cmd_get_rsp(struct rtsx_usb_sdmmc *host,
case MMC_RSP_R1:
rsp_type = SD_RSP_TYPE_R1;
break;
- case MMC_RSP_R1_NO_CRC:
- rsp_type = SD_RSP_TYPE_R1 | SD_NO_CHECK_CRC7;
- break;
case MMC_RSP_R1B:
rsp_type = SD_RSP_TYPE_R1b;
break;
diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c
index 45a474ccab1c..04c1c54df791 100644
--- a/drivers/mmc/host/tmio_mmc_core.c
+++ b/drivers/mmc/host/tmio_mmc_core.c
@@ -297,7 +297,6 @@ static int tmio_mmc_start_command(struct tmio_mmc_host *host,
switch (mmc_resp_type(cmd)) {
case MMC_RSP_NONE: c |= RESP_NONE; break;
case MMC_RSP_R1:
- case MMC_RSP_R1_NO_CRC:
c |= RESP_R1; break;
case MMC_RSP_R1B: c |= RESP_R1B; break;
case MMC_RSP_R2: c |= RESP_R2; break;
diff --git a/include/linux/mmc/core.h b/include/linux/mmc/core.h
index 56972bd78462..e13856ab6ad0 100644
--- a/include/linux/mmc/core.h
+++ b/include/linux/mmc/core.h
@@ -64,9 +64,6 @@ struct mmc_command {
#define MMC_RSP_R6 (MMC_RSP_PRESENT|MMC_RSP_CRC|MMC_RSP_OPCODE)
#define MMC_RSP_R7 (MMC_RSP_PRESENT|MMC_RSP_CRC|MMC_RSP_OPCODE)
-/* Can be used by core to poll after switch to MMC HS mode */
-#define MMC_RSP_R1_NO_CRC (MMC_RSP_PRESENT|MMC_RSP_OPCODE)
-
#define mmc_resp_type(cmd) ((cmd)->flags & (MMC_RSP_PRESENT|MMC_RSP_136|MMC_RSP_CRC|MMC_RSP_BUSY|MMC_RSP_OPCODE))
/*
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: core: Drop the MMC_RSP_R1_NO_CRC response
2024-11-25 13:23 [PATCH] mmc: core: Drop the MMC_RSP_R1_NO_CRC response Ulf Hansson
@ 2024-11-25 16:04 ` Wolfram Sang
2024-11-26 7:50 ` Avri Altman
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2024-11-25 16:04 UTC (permalink / raw)
To: Ulf Hansson; +Cc: linux-mmc, Adrian Hunter, Andy-ld Lu, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 378 bytes --]
On Mon, Nov 25, 2024 at 02:23:11PM +0100, Ulf Hansson wrote:
> The MMC_RSP_R1_NO_CRC type of response is not being used by the mmc core
> for any commands. Let's therefore drop it, together with the corresponding
> code in the host drivers.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com> # for TMIO
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] mmc: core: Drop the MMC_RSP_R1_NO_CRC response
2024-11-25 13:23 [PATCH] mmc: core: Drop the MMC_RSP_R1_NO_CRC response Ulf Hansson
2024-11-25 16:04 ` Wolfram Sang
@ 2024-11-26 7:50 ` Avri Altman
1 sibling, 0 replies; 3+ messages in thread
From: Avri Altman @ 2024-11-26 7:50 UTC (permalink / raw)
To: Ulf Hansson, linux-mmc
Cc: Adrian Hunter, Andy-ld Lu, Wolfram Sang, linux-kernel
> The MMC_RSP_R1_NO_CRC type of response is not being used by the mmc
> core for any commands. Let's therefore drop it, together with the
> corresponding code in the host drivers.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
> ---
> drivers/mmc/host/rtsx_pci_sdmmc.c | 2 --
> drivers/mmc/host/rtsx_usb_sdmmc.c | 3 ---
> drivers/mmc/host/tmio_mmc_core.c | 1 -
> include/linux/mmc/core.h | 3 ---
> 4 files changed, 9 deletions(-)
>
> diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c
> b/drivers/mmc/host/rtsx_pci_sdmmc.c
> index 48d3b0aae5a0..0c6eb60a95fd 100644
> --- a/drivers/mmc/host/rtsx_pci_sdmmc.c
> +++ b/drivers/mmc/host/rtsx_pci_sdmmc.c
> @@ -115,8 +115,6 @@ static int sd_response_type(struct mmc_command
> *cmd)
> return SD_RSP_TYPE_R0;
> case MMC_RSP_R1:
> return SD_RSP_TYPE_R1;
> - case MMC_RSP_R1_NO_CRC:
> - return SD_RSP_TYPE_R1 | SD_NO_CHECK_CRC7;
> case MMC_RSP_R1B:
> return SD_RSP_TYPE_R1b;
> case MMC_RSP_R2:
> diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c
> b/drivers/mmc/host/rtsx_usb_sdmmc.c
> index 107c78df53cf..d229c2b83ea9 100644
> --- a/drivers/mmc/host/rtsx_usb_sdmmc.c
> +++ b/drivers/mmc/host/rtsx_usb_sdmmc.c
> @@ -313,9 +313,6 @@ static void sd_send_cmd_get_rsp(struct
> rtsx_usb_sdmmc *host,
> case MMC_RSP_R1:
> rsp_type = SD_RSP_TYPE_R1;
> break;
> - case MMC_RSP_R1_NO_CRC:
> - rsp_type = SD_RSP_TYPE_R1 | SD_NO_CHECK_CRC7;
> - break;
> case MMC_RSP_R1B:
> rsp_type = SD_RSP_TYPE_R1b;
> break;
> diff --git a/drivers/mmc/host/tmio_mmc_core.c
> b/drivers/mmc/host/tmio_mmc_core.c
> index 45a474ccab1c..04c1c54df791 100644
> --- a/drivers/mmc/host/tmio_mmc_core.c
> +++ b/drivers/mmc/host/tmio_mmc_core.c
> @@ -297,7 +297,6 @@ static int tmio_mmc_start_command(struct
> tmio_mmc_host *host,
> switch (mmc_resp_type(cmd)) {
> case MMC_RSP_NONE: c |= RESP_NONE; break;
> case MMC_RSP_R1:
> - case MMC_RSP_R1_NO_CRC:
> c |= RESP_R1; break;
> case MMC_RSP_R1B: c |= RESP_R1B; break;
> case MMC_RSP_R2: c |= RESP_R2; break;
> diff --git a/include/linux/mmc/core.h b/include/linux/mmc/core.h index
> 56972bd78462..e13856ab6ad0 100644
> --- a/include/linux/mmc/core.h
> +++ b/include/linux/mmc/core.h
> @@ -64,9 +64,6 @@ struct mmc_command {
> #define MMC_RSP_R6
> (MMC_RSP_PRESENT|MMC_RSP_CRC|MMC_RSP_OPCODE)
> #define MMC_RSP_R7
> (MMC_RSP_PRESENT|MMC_RSP_CRC|MMC_RSP_OPCODE)
>
> -/* Can be used by core to poll after switch to MMC HS mode */
> -#define MMC_RSP_R1_NO_CRC
> (MMC_RSP_PRESENT|MMC_RSP_OPCODE)
> -
> #define mmc_resp_type(cmd) ((cmd)->flags &
> (MMC_RSP_PRESENT|MMC_RSP_136|MMC_RSP_CRC|MMC_RSP_BUSY|MMC
> _RSP_OPCODE))
>
> /*
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-26 7:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-25 13:23 [PATCH] mmc: core: Drop the MMC_RSP_R1_NO_CRC response Ulf Hansson
2024-11-25 16:04 ` Wolfram Sang
2024-11-26 7:50 ` Avri Altman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®