From: Uladzislau Rezki <urezki@gmail.com>
To: "Paul E. McKenney" <paulmck@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>
Cc: Frederic Weisbecker <frederic@kernel.org>,
rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com, rostedt@goodmis.org, urezki@gmail.com
Subject: Re: [PATCH rcu 1/2] rcu/nocb: Use switch/case on NOCB timer state machine
Date: Sat, 14 Dec 2024 17:20:37 +0100 [thread overview]
Message-ID: <Z12wVQjxqlZJuP0K@pc638.lan> (raw)
In-Reply-To: <0d069012-ab5f-4126-89b4-5f2c186b18ae@paulmck-laptop>
On Fri, Dec 13, 2024 at 03:29:16PM -0800, Paul E. McKenney wrote:
> On Sat, Dec 14, 2024 at 12:08:42AM +0100, Frederic Weisbecker wrote:
> > Le Thu, Dec 12, 2024 at 10:42:13AM -0800, Paul E. McKenney a écrit :
> > > From: Frederic Weisbecker <frederic@kernel.org>
> > >
> > > It's more convenient to benefit from the fallthrough feature of
> > > switch / case to handle the timer state machine. Also a new state is
> > > about to be added that will take advantage of it.
> > >
> > > No intended functional change.
> > >
> > > Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
> > > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> >
> > Please drop this one too. It introduced a subtle (yet desired) behaviour
> > change as Boqun noted. I'll resend a better version.
>
> I will drop both on my next rebase. Uladzislau, over to you!
>
Thank you. Dropped both.
--
Uladzislau Rezki
next prev parent reply other threads:[~2024-12-14 16:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 18:42 [PATCH rcu 0/2] No-CB changes for v6.14 Paul E. McKenney
2024-12-12 18:42 ` [PATCH rcu 1/2] rcu/nocb: Use switch/case on NOCB timer state machine Paul E. McKenney
2024-12-13 23:08 ` Frederic Weisbecker
2024-12-13 23:29 ` Paul E. McKenney
2024-12-14 16:20 ` Uladzislau Rezki [this message]
2024-12-12 18:42 ` [PATCH rcu 2/2] rcu/nocb: Fix rcuog wake-up from offline softirq Paul E. McKenney
2024-12-13 23:07 ` Frederic Weisbecker
2024-12-14 16:16 ` Uladzislau Rezki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z12wVQjxqlZJuP0K@pc638.lan \
--to=urezki@gmail.com \
--cc=frederic@kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®