From: Herbert Xu <herbert@gondor.apana.org.au>
To: Chenghai Huang <huangchenghai2@huawei.com>
Cc: davem@davemloft.net, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org, liulongfang@huawei.com,
qianweili@huawei.com, linwenkai6@hisilicon.com
Subject: Re: [PATCH v4 2/2] crypto: hisilicon/sec2 - fix for aead invalid authsize
Date: Tue, 10 Dec 2024 11:31:12 +0800 [thread overview]
Message-ID: <Z1e2APBqSnl8ayyu@gondor.apana.org.au> (raw)
In-Reply-To: <20241115102139.3793659-3-huangchenghai2@huawei.com>
On Fri, Nov 15, 2024 at 06:21:39PM +0800, Chenghai Huang wrote:
>
> + a_ctx->fallback = false;
Is this field still used anywhere? If not please remove it. It's
confusing to have two fallback fields.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2024-12-10 3:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 10:21 [PATCH v4 0/2] crypto: hisilicon - fix the authsize and icv problems of aead in sec Chenghai Huang
2024-11-15 10:21 ` [PATCH v4 1/2] crypto: hisilicon/sec2 - fix for aead icv error Chenghai Huang
2024-11-15 10:21 ` [PATCH v4 2/2] crypto: hisilicon/sec2 - fix for aead invalid authsize Chenghai Huang
2024-12-10 3:31 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1e2APBqSnl8ayyu@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=huangchenghai2@huawei.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linwenkai6@hisilicon.com \
--cc=liulongfang@huawei.com \
--cc=qianweili@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®