From: Christoph Hellwig <hch@infradead.org>
To: Kevin Brodsky <kevin.brodsky@arm.com>
Cc: Christoph Hellwig <hch@infradead.org>,
x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de,
dan.j.williams@intel.com, dave.hansen@linux.intel.com,
david@redhat.com, jane.chu@oracle.com, osalvador@suse.de,
tglx@linutronix.de
Subject: Re: [PATCH 0/4] Remove problematic include in <asm/set_memory.h>
Date: Wed, 11 Dec 2024 21:46:54 -0800 [thread overview]
Message-ID: <Z1p4zp1qnVyY-C2L@infradead.org> (raw)
In-Reply-To: <490f7554-62eb-48a3-a45d-a65e68794b58@arm.com>
On Wed, Dec 11, 2024 at 09:14:07AM +0100, Kevin Brodsky wrote:
> On 11/12/2024 06:04, Christoph Hellwig wrote:
> > On Tue, Dec 10, 2024 at 06:46:06PM +0000, Kevin Brodsky wrote:
> >> The need for this series arose from a completely unrelated series [1].
> >> Long story short, that series causes <linux/mm.h> to include
> >> <linux/set_memory.h>, which doesn't feel too unreasonable.
> > It is entirely unreasoable. <linux/mm.h> is inclued just about
> > everywhere and should not grow more fringe includes.
>
> Understood, I did wonder about that. Then I suppose the best course of
> action for the problematic patch in that other series [3] is to move
> pagetable_{alloc,free} out of linux/mm.h.
Yes, adding a new header for the page table helpers only used by arch
code is probably a good idea. Or maybe they can actually fit into
asm-generic/pgalloc.h?
prev parent reply other threads:[~2024-12-12 5:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 18:46 Kevin Brodsky
2024-12-10 18:46 ` [PATCH 1/4] x86/smp: Explicitly include <linux/thread_info.h> Kevin Brodsky
2024-12-10 21:36 ` Borislav Petkov
2024-12-11 8:06 ` Kevin Brodsky
2024-12-10 18:46 ` [PATCH 2/4] x86/sev: Explicitly include <linux/mm.h> Kevin Brodsky
2024-12-10 18:46 ` [PATCH 3/4] x86/mm: Remove unused __set_memory_prot() Kevin Brodsky
2024-12-10 18:46 ` [PATCH 4/4] x86/mm: Remove unnecessary include in set_memory.h Kevin Brodsky
2024-12-10 19:57 ` [PATCH 0/4] Remove problematic include in <asm/set_memory.h> David Hildenbrand
2024-12-11 5:04 ` Christoph Hellwig
2024-12-11 8:14 ` Kevin Brodsky
2024-12-12 5:46 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1p4zp1qnVyY-C2L@infradead.org \
--to=hch@infradead.org \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=jane.chu@oracle.com \
--cc=kevin.brodsky@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=osalvador@suse.de \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®