From: Kevin Brodsky <kevin.brodsky@arm.com>
To: Borislav Petkov <bp@alien8.de>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
dan.j.williams@intel.com, dave.hansen@linux.intel.com,
david@redhat.com, jane.chu@oracle.com, osalvador@suse.de,
tglx@linutronix.de
Subject: Re: [PATCH 1/4] x86/smp: Explicitly include <linux/thread_info.h>
Date: Wed, 11 Dec 2024 09:06:02 +0100 [thread overview]
Message-ID: <c06157f3-08ac-4071-9410-82861bbf0fb5@arm.com> (raw)
In-Reply-To: <20241210213626.GNZ1i0WsS0XCoaoEY1@fat_crate.local>
On 10/12/2024 22:36, Borislav Petkov wrote:
> On Tue, Dec 10, 2024 at 06:46:07PM +0000, Kevin Brodsky wrote:
>> diff --git a/arch/x86/include/asm/smp.h b/arch/x86/include/asm/smp.h
>> index ca073f40698f..88e72b414bfa 100644
>> --- a/arch/x86/include/asm/smp.h
>> +++ b/arch/x86/include/asm/smp.h
>> @@ -6,7 +6,7 @@
>>
>> #include <asm/cpumask.h>
>> #include <asm/current.h>
>> -#include <asm/thread_info.h>
>> +#include <linux/thread_info.h>
> linux/ namespace headers come before asm/ ones, I'd say.
Oops, meant to move it but forgot, thanks!
> But, more importantly, why is this 4 patches instead of 2:
>
> 1. Remove unused __set_memory_prot
> 2. Fixup include hell
Totally fine by me. I wasn't sure that touching
drivers/virt/coco/sev-guest in the same patch as arch/x86 was ok, but
sounds like it is.
- Kevin
next prev parent reply other threads:[~2024-12-11 8:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 18:46 [PATCH 0/4] Remove problematic include in <asm/set_memory.h> Kevin Brodsky
2024-12-10 18:46 ` [PATCH 1/4] x86/smp: Explicitly include <linux/thread_info.h> Kevin Brodsky
2024-12-10 21:36 ` Borislav Petkov
2024-12-11 8:06 ` Kevin Brodsky [this message]
2024-12-10 18:46 ` [PATCH 2/4] x86/sev: Explicitly include <linux/mm.h> Kevin Brodsky
2024-12-10 18:46 ` [PATCH 3/4] x86/mm: Remove unused __set_memory_prot() Kevin Brodsky
2024-12-10 18:46 ` [PATCH 4/4] x86/mm: Remove unnecessary include in set_memory.h Kevin Brodsky
2024-12-10 19:57 ` [PATCH 0/4] Remove problematic include in <asm/set_memory.h> David Hildenbrand
2024-12-11 5:04 ` Christoph Hellwig
2024-12-11 8:14 ` Kevin Brodsky
2024-12-12 5:46 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c06157f3-08ac-4071-9410-82861bbf0fb5@arm.com \
--to=kevin.brodsky@arm.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=jane.chu@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=osalvador@suse.de \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®