mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Yu-Chun Lin <eleanor15x@gmail.com>,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
	ruanjinjie@huawei.com, jserv@ccns.ncku.edu.tw,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] drm/tests: helpers: Fix compile wrarning
Date: Sat, 4 Jan 2025 05:43:54 +0800	[thread overview]
Message-ID: <Z3haGne8A0sJHnFF@visitorckw-System-Product-Name> (raw)
In-Reply-To: <rpeh5mcy4xumebqojfoevvfar5dw4jmvuwt3btjklr4gohqhfs@fjqt6nbcpf4k>

Hi Dmitry,

On Fri, Jan 03, 2025 at 08:14:20PM +0200, Dmitry Baryshkov wrote:
> On Sat, Jan 04, 2025 at 12:17:58AM +0800, Yu-Chun Lin wrote:
> > Delete one line break to make the format correct, resolving the
> > following warning during a W=1 build:
> > 
> > >> drivers/gpu/drm/tests/drm_kunit_helpers.c:324: warning: bad line: for a KUnit test
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202501032001.O6WY1VCW-lkp@intel.com/
> > Reviewed-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> 
> Reviewed where?
> 
Yu-Chun is a newcomer looking to contribute to Linux and asked for my
help. As suggested in the last section of [1], she asked me to review
her patch privately before sending it to the public mailing list and
include my Reviewed-by tag. This improves patch quality and reduces
the maintainer's workload by minimizing potential issues.

Although I'm not a DRM developer, I have been contributing to Linux for
some time and wanted to provide support.

[1]: Documentation/process/researcher-guidelines.rst

> > Tested-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> > Signed-off-by: Yu-Chun Lin <eleanor15x@gmail.com>
> > ---
> >  drivers/gpu/drm/tests/drm_kunit_helpers.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
Thanks for your review!

Regards,
Kuan-Wei

  reply	other threads:[~2025-01-03 21:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-03 16:17 Yu-Chun Lin
2025-01-03 18:14 ` Dmitry Baryshkov
2025-01-03 21:43   ` Kuan-Wei Chiu [this message]
2025-01-03 22:16     ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z3haGne8A0sJHnFF@visitorckw-System-Product-Name \
    --to=visitorckw@gmail.com \
    --cc=airlied@gmail.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eleanor15x@gmail.com \
    --cc=jserv@ccns.ncku.edu.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=ruanjinjie@huawei.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®