mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Imran Khan <imran.f.khan@oracle.com>
Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] workqueue: introduce queue_delayed_work_on_offline_safe.
Date: Mon, 13 Jan 2025 08:21:36 -1000	[thread overview]
Message-ID: <Z4VZsFBn13nBnGjb@slm.duckdns.org> (raw)
In-Reply-To: <20250113043540.2396426-1-imran.f.khan@oracle.com>

On Mon, Jan 13, 2025 at 03:35:40PM +1100, Imran Khan wrote:
...
> I have kept the patch as RFC because from mailing list,
> I could not find any users, of queue_delayed_work_on,
> that is ending up queuing dwork on an offlined CPU.
> We have some in-house code that is running into this problem,
> and currently we are fixing it on caller side of queue_delayed_work_on.
> Other users who run into this issue, can also use the approach of
> fixing it on caller side or we can use the interface introduced
> here for such use cases.

I'm not sure how necessary this is. If the timer is okay to run on other
CPUs, might as well just use queue_delayed_work().

Thanks.

-- 
tejun

  reply	other threads:[~2025-01-13 18:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-13  4:35 Imran Khan
2025-01-13 18:21 ` Tejun Heo [this message]
2025-01-14  3:01   ` imran.f.khan
2025-01-17  5:27     ` imran.f.khan
2025-01-31 10:37     ` imran.f.khan
2025-01-31 11:16       ` imran.f.khan
2025-02-03 11:48         ` Haakon Bugge
2025-02-04  5:54           ` imran.f.khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z4VZsFBn13nBnGjb@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=imran.f.khan@oracle.com \
    --cc=jiangshanlai@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®