* [PATCH] drm: drop i2c subdir from Makefile
@ 2025-02-13 0:49 Dmitry Baryshkov
2025-02-13 1:18 ` Matthew Brost
2025-02-13 2:11 ` Dmitry Baryshkov
0 siblings, 2 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-02-13 0:49 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Neil Armstrong, Laurent Pinchart,
Liviu Dudau
Cc: dri-devel, linux-kernel, Stephen Rothwell
The commit 325ba852d148 ("drm/i2c: move TDA998x driver under
drivers/gpu/drm/bridge") deleted the drivers/gpu/drm/i2c/ subdir, but
didn't update upper level Makefile. Drop corresponding line to fix build
issues.
Fixes: 325ba852d148 ("drm/i2c: move TDA998x driver under drivers/gpu/drm/bridge")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/dri-devel/20250213113841.7645b74c@canb.auug.org.au
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/gpu/drm/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
index 42901f877bf256765829b5fe25bf7844202338cb..50604b49d1ac4edd439ea73361118fd1e6a81d53 100644
--- a/drivers/gpu/drm/Makefile
+++ b/drivers/gpu/drm/Makefile
@@ -197,7 +197,6 @@ obj-$(CONFIG_DRM_INGENIC) += ingenic/
obj-$(CONFIG_DRM_LOGICVC) += logicvc/
obj-$(CONFIG_DRM_MEDIATEK) += mediatek/
obj-$(CONFIG_DRM_MESON) += meson/
-obj-y += i2c/
obj-y += panel/
obj-y += bridge/
obj-$(CONFIG_DRM_FSL_DCU) += fsl-dcu/
---
base-commit: 325ba852d148434c5bcb06d513af1933a7f77b70
change-id: 20250213-fix-tda-74b6916aaa00
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm: drop i2c subdir from Makefile
2025-02-13 0:49 [PATCH] drm: drop i2c subdir from Makefile Dmitry Baryshkov
@ 2025-02-13 1:18 ` Matthew Brost
2025-02-13 2:12 ` Dmitry Baryshkov
2025-02-13 2:11 ` Dmitry Baryshkov
1 sibling, 1 reply; 4+ messages in thread
From: Matthew Brost @ 2025-02-13 1:18 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Neil Armstrong, Laurent Pinchart,
Liviu Dudau, dri-devel, linux-kernel, Stephen Rothwell
On Thu, Feb 13, 2025 at 02:49:41AM +0200, Dmitry Baryshkov wrote:
> The commit 325ba852d148 ("drm/i2c: move TDA998x driver under
> drivers/gpu/drm/bridge") deleted the drivers/gpu/drm/i2c/ subdir, but
> didn't update upper level Makefile. Drop corresponding line to fix build
> issues.
>
> Fixes: 325ba852d148 ("drm/i2c: move TDA998x driver under drivers/gpu/drm/bridge")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/dri-devel/20250213113841.7645b74c@canb.auug.org.au
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Our CI caught this too. Thanks for the quick fix.
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
> ---
> drivers/gpu/drm/Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
> index 42901f877bf256765829b5fe25bf7844202338cb..50604b49d1ac4edd439ea73361118fd1e6a81d53 100644
> --- a/drivers/gpu/drm/Makefile
> +++ b/drivers/gpu/drm/Makefile
> @@ -197,7 +197,6 @@ obj-$(CONFIG_DRM_INGENIC) += ingenic/
> obj-$(CONFIG_DRM_LOGICVC) += logicvc/
> obj-$(CONFIG_DRM_MEDIATEK) += mediatek/
> obj-$(CONFIG_DRM_MESON) += meson/
> -obj-y += i2c/
> obj-y += panel/
> obj-y += bridge/
> obj-$(CONFIG_DRM_FSL_DCU) += fsl-dcu/
>
> ---
> base-commit: 325ba852d148434c5bcb06d513af1933a7f77b70
> change-id: 20250213-fix-tda-74b6916aaa00
>
> Best regards,
> --
> Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm: drop i2c subdir from Makefile
2025-02-13 1:18 ` Matthew Brost
@ 2025-02-13 2:12 ` Dmitry Baryshkov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-02-13 2:12 UTC (permalink / raw)
To: Matthew Brost
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Neil Armstrong, Laurent Pinchart,
Liviu Dudau, dri-devel, linux-kernel, Stephen Rothwell
On Wed, Feb 12, 2025 at 05:18:03PM -0800, Matthew Brost wrote:
> On Thu, Feb 13, 2025 at 02:49:41AM +0200, Dmitry Baryshkov wrote:
> > The commit 325ba852d148 ("drm/i2c: move TDA998x driver under
> > drivers/gpu/drm/bridge") deleted the drivers/gpu/drm/i2c/ subdir, but
> > didn't update upper level Makefile. Drop corresponding line to fix build
> > issues.
> >
> > Fixes: 325ba852d148 ("drm/i2c: move TDA998x driver under drivers/gpu/drm/bridge")
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Closes: https://lore.kernel.org/dri-devel/20250213113841.7645b74c@canb.auug.org.au
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> Our CI caught this too. Thanks for the quick fix.
Thanks for the quick review!
>
> Reviewed-by: Matthew Brost <matthew.brost@intel.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: drop i2c subdir from Makefile
2025-02-13 0:49 [PATCH] drm: drop i2c subdir from Makefile Dmitry Baryshkov
2025-02-13 1:18 ` Matthew Brost
@ 2025-02-13 2:11 ` Dmitry Baryshkov
1 sibling, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-02-13 2:11 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Neil Armstrong, Laurent Pinchart,
Liviu Dudau, Dmitry Baryshkov
Cc: dri-devel, linux-kernel, Stephen Rothwell
On Thu, 13 Feb 2025 02:49:41 +0200, Dmitry Baryshkov wrote:
> The commit 325ba852d148 ("drm/i2c: move TDA998x driver under
> drivers/gpu/drm/bridge") deleted the drivers/gpu/drm/i2c/ subdir, but
> didn't update upper level Makefile. Drop corresponding line to fix build
> issues.
>
>
Applied to drm-misc-next, thanks!
[1/1] drm: drop i2c subdir from Makefile
commit: efc84f661e0a1b73449d678a89ad86d61bbf6bf4
Best regards,
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-02-13 2:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-13 0:49 [PATCH] drm: drop i2c subdir from Makefile Dmitry Baryshkov
2025-02-13 1:18 ` Matthew Brost
2025-02-13 2:12 ` Dmitry Baryshkov
2025-02-13 2:11 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®