* [PATCH v4 1/2] drm/drm_mode_object: fix typo in kerneldoc
2025-02-04 8:51 [PATCH v4 0/2] DRM: small improvements Luca Ceresoli
@ 2025-02-04 8:51 ` Luca Ceresoli
2025-02-04 8:51 ` [PATCH v4 2/2] drm/atomic-helper: improve CRTC enabled/connectors mismatch logging message Luca Ceresoli
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Luca Ceresoli @ 2025-02-04 8:51 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter
Cc: Dmitry Baryshkov, Jani Nikula, Thomas Petazzoni, Louis Chauvet,
dri-devel, linux-kernel, Luca Ceresoli
Remove unintended extra word.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Acked-by: Louis Chauvet <louis.chauvet@bootlin.com>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
include/drm/drm_mode_object.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_mode_object.h b/include/drm/drm_mode_object.h
index 08d7a7f0188fea79e2d8ad5ee6cc5044300f1a26..c68edbd126d04d51221f50aa2b4166475543b59f 100644
--- a/include/drm/drm_mode_object.h
+++ b/include/drm/drm_mode_object.h
@@ -35,7 +35,7 @@ struct drm_file;
* @id: userspace visible identifier
* @type: type of the object, one of DRM_MODE_OBJECT\_\*
* @properties: properties attached to this object, including values
- * @refcount: reference count for objects which with dynamic lifetime
+ * @refcount: reference count for objects with dynamic lifetime
* @free_cb: free function callback, only set for objects with dynamic lifetime
*
* Base structure for modeset objects visible to userspace. Objects can be
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v4 2/2] drm/atomic-helper: improve CRTC enabled/connectors mismatch logging message
2025-02-04 8:51 [PATCH v4 0/2] DRM: small improvements Luca Ceresoli
2025-02-04 8:51 ` [PATCH v4 1/2] drm/drm_mode_object: fix typo in kerneldoc Luca Ceresoli
@ 2025-02-04 8:51 ` Luca Ceresoli
2025-02-04 10:29 ` [PATCH v4 0/2] DRM: small improvements Simona Vetter
2025-02-04 13:12 ` Louis Chauvet
3 siblings, 0 replies; 5+ messages in thread
From: Luca Ceresoli @ 2025-02-04 8:51 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter
Cc: Dmitry Baryshkov, Jani Nikula, Thomas Petazzoni, Louis Chauvet,
dri-devel, linux-kernel, Luca Ceresoli
This message reports a mismatch between new_crtc_state->enable and
has_connectors, which should be either both true or both false. However it
does not mention which one is true and which is false, which can be useful
for debugging. Add the value of both avriables to the log message.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Acked-by: Louis Chauvet <louis.chauvet@bootlin.com>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
drivers/gpu/drm/drm_atomic_helper.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
index 5186d2114a503701e228e382cc45180b0c578d0c..8ed186ddaeafae8295696eb11ace58777a5d9e43 100644
--- a/drivers/gpu/drm/drm_atomic_helper.c
+++ b/drivers/gpu/drm/drm_atomic_helper.c
@@ -666,8 +666,9 @@ drm_atomic_helper_check_modeset(struct drm_device *dev,
}
if (new_crtc_state->enable != has_connectors) {
- drm_dbg_atomic(dev, "[CRTC:%d:%s] enabled/connectors mismatch\n",
- crtc->base.id, crtc->name);
+ drm_dbg_atomic(dev, "[CRTC:%d:%s] enabled/connectors mismatch (%d/%d)\n",
+ crtc->base.id, crtc->name,
+ new_crtc_state->enable, has_connectors);
return -EINVAL;
}
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v4 0/2] DRM: small improvements
2025-02-04 8:51 [PATCH v4 0/2] DRM: small improvements Luca Ceresoli
2025-02-04 8:51 ` [PATCH v4 1/2] drm/drm_mode_object: fix typo in kerneldoc Luca Ceresoli
2025-02-04 8:51 ` [PATCH v4 2/2] drm/atomic-helper: improve CRTC enabled/connectors mismatch logging message Luca Ceresoli
@ 2025-02-04 10:29 ` Simona Vetter
2025-02-04 13:12 ` Louis Chauvet
3 siblings, 0 replies; 5+ messages in thread
From: Simona Vetter @ 2025-02-04 10:29 UTC (permalink / raw)
To: Luca Ceresoli
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Dmitry Baryshkov, Jani Nikula,
Thomas Petazzoni, Louis Chauvet, dri-devel, linux-kernel
On Tue, Feb 04, 2025 at 09:51:57AM +0100, Luca Ceresoli wrote:
> This series brings small improvements to the DRM documentation and logging.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
I've seen these fly by a few times ... is there no one at bootlin with
drm-misc commit rights who can push these for you? That's how I at least
expected these to land a few revisions ago.
Cheers, Sima
> ---
> Changes in v4:
> - Removed pathches 3 and 4 because the added warning has false positives
> when cleaning up a connector in the init error path
> - Updated acked-by tags
> - Link to v3: https://lore.kernel.org/r/20241111-drm-small-improvements-v3-0-a9f576111b41@bootlin.com
>
> Changes in v3:
> - patch 3: various fixes suggested by Jani Nikula and kernel test robot
> - Updated reviewed-by tags
> - Link to v2: https://lore.kernel.org/r/20241106-drm-small-improvements-v2-0-f6e2aef86719@bootlin.com
>
> Changes in v2:
> - Added patches 3 and 4
> - Updated reviewed-by tags
> - Link to v1: https://lore.kernel.org/r/20241018-drm-small-improvements-v1-0-cc316e1a98c9@bootlin.com
>
> ---
> Luca Ceresoli (2):
> drm/drm_mode_object: fix typo in kerneldoc
> drm/atomic-helper: improve CRTC enabled/connectors mismatch logging message
>
> drivers/gpu/drm/drm_atomic_helper.c | 5 +++--
> include/drm/drm_mode_object.h | 2 +-
> 2 files changed, 4 insertions(+), 3 deletions(-)
> ---
> base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
> change-id: 20241018-drm-small-improvements-1d104cc10280
>
> Best regards,
> --
> Luca Ceresoli <luca.ceresoli@bootlin.com>
>
--
Simona Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4 0/2] DRM: small improvements
2025-02-04 8:51 [PATCH v4 0/2] DRM: small improvements Luca Ceresoli
` (2 preceding siblings ...)
2025-02-04 10:29 ` [PATCH v4 0/2] DRM: small improvements Simona Vetter
@ 2025-02-04 13:12 ` Louis Chauvet
3 siblings, 0 replies; 5+ messages in thread
From: Louis Chauvet @ 2025-02-04 13:12 UTC (permalink / raw)
To: Luca Ceresoli
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Dmitry Baryshkov, Jani Nikula,
Thomas Petazzoni, dri-devel, linux-kernel
On 04/02/25 - 09:51, Luca Ceresoli wrote:
> This series brings small improvements to the DRM documentation and logging.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Applied on drm-misc-next, thanks.
Louis Chauvet
> ---
> Changes in v4:
> - Removed pathches 3 and 4 because the added warning has false positives
> when cleaning up a connector in the init error path
> - Updated acked-by tags
> - Link to v3: https://lore.kernel.org/r/20241111-drm-small-improvements-v3-0-a9f576111b41@bootlin.com
>
> Changes in v3:
> - patch 3: various fixes suggested by Jani Nikula and kernel test robot
> - Updated reviewed-by tags
> - Link to v2: https://lore.kernel.org/r/20241106-drm-small-improvements-v2-0-f6e2aef86719@bootlin.com
>
> Changes in v2:
> - Added patches 3 and 4
> - Updated reviewed-by tags
> - Link to v1: https://lore.kernel.org/r/20241018-drm-small-improvements-v1-0-cc316e1a98c9@bootlin.com
>
> ---
> Luca Ceresoli (2):
> drm/drm_mode_object: fix typo in kerneldoc
> drm/atomic-helper: improve CRTC enabled/connectors mismatch logging message
>
> drivers/gpu/drm/drm_atomic_helper.c | 5 +++--
> include/drm/drm_mode_object.h | 2 +-
> 2 files changed, 4 insertions(+), 3 deletions(-)
> ---
> base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
> change-id: 20241018-drm-small-improvements-1d104cc10280
>
> Best regards,
> --
> Luca Ceresoli <luca.ceresoli@bootlin.com>
>
^ permalink raw reply [flat|nested] 5+ messages in thread