mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Juri Lelli <juri.lelli@redhat.com>
To: Shrikanth Hegde <sshegde@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
	peterz@infradead.org, vincent.guittot@linaro.org,
	dietmar.eggemann@arm.com, rostedt@goodmis.org,
	bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
	hbathini@linux.ibm.com, joelagnelf@nvidia.com
Subject: Re: [PATCH 2/2] sched/rt: update limit of sched_rt sysctl in documentation
Date: Thu, 6 Mar 2025 08:34:02 +0000	[thread overview]
Message-ID: <Z8ld-hutVNH3_aXF@jlelli-thinkpadt14gen4.remote.csb> (raw)
In-Reply-To: <20250306052954.452005-3-sshegde@linux.ibm.com>

Hi,

On 06/03/25 10:59, Shrikanth Hegde wrote:
> By default fair_server dl_server allocates 5% of the bandwidth to the root
> domain. Due to this writing any value less than 5% fails due to -EBUSY.
> 
> cat /proc/sys/kernel/sched_rt_period_us
> 1000000
> $ echo 49999 > /proc/sys/kernel/sched_rt_runtime_us
> -bash: echo: write error: Device or resource busy
> $ echo 50000 > /proc/sys/kernel/sched_rt_runtime_us
> $
> 
> Since the sched_rt_runtime_us allows -1 as the minimum, put this
> restriction in the documentation.
> 
> One should check average of runtime/period in 
> /sys/kernel/debug/sched/fair_server/cpuX/* for exact value.
> 
> Signed-off-by: Shrikanth Hegde <sshegde@linux.ibm.com>
> ---
>  Documentation/scheduler/sched-rt-group.rst | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/scheduler/sched-rt-group.rst b/Documentation/scheduler/sched-rt-group.rst
> index 80b05a3009ea..ab464335d320 100644
> --- a/Documentation/scheduler/sched-rt-group.rst
> +++ b/Documentation/scheduler/sched-rt-group.rst
> @@ -102,6 +102,9 @@ The system wide settings are configured under the /proc virtual file system:
>    * sched_rt_period_us takes values from 1 to INT_MAX.
>    * sched_rt_runtime_us takes values from -1 to sched_rt_period_us.
>    * A run time of -1 specifies runtime == period, ie. no limit.
> +  * sched_rt_runtime_us/sched_rt_period_us > 0.05 inorder to preserve
> +    bandwidth for fair dl_server. For accurate value check average of
> +    runtime/period in /sys/kernel/debug/sched/fair_server/cpuX/

Looks good to me.

Reviewed-by: Juri Lelli <juri.lelli@redhat.com>

Thanks!
Juri


  reply	other threads:[~2025-03-06  8:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-06  5:29 [PATCH 0/2] sched: issues with sched_rt_runtime_us Shrikanth Hegde
2025-03-06  5:29 ` [PATCH 1/2] sched/deadline: use online cpus for validating runtime Shrikanth Hegde
2025-03-06  8:29   ` Juri Lelli
2025-03-06 10:02   ` [tip: sched/urgent] sched/deadline: Use " tip-bot2 for Shrikanth Hegde
2025-03-06  5:29 ` [PATCH 2/2] sched/rt: update limit of sched_rt sysctl in documentation Shrikanth Hegde
2025-03-06  8:34   ` Juri Lelli [this message]
2025-03-06 10:02   ` [tip: sched/urgent] sched/rt: Update " tip-bot2 for Shrikanth Hegde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z8ld-hutVNH3_aXF@jlelli-thinkpadt14gen4.remote.csb \
    --to=juri.lelli@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=hbathini@linux.ibm.com \
    --cc=joelagnelf@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sshegde@linux.ibm.com \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®