From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: shravan kumar <shravan.chippa@microchip.com>
Cc: mchehab@kernel.org, kieran.bingham@ideasonboard.com,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
conor.dooley@microchip.com,
valentina.fernandezalanis@microchip.com,
praveen.kumar@microchip.com
Subject: Re: [PATCH V7 2/4] media: i2c: imx334: common reg value correction
Date: Tue, 11 Mar 2025 09:47:48 +0000 [thread overview]
Message-ID: <Z9AGxJuk7V-QPKW1@kekkonen.localdomain> (raw)
In-Reply-To: <20250305051442.3716817-3-shravan.chippa@microchip.com>
Hi Shravan,
On Wed, Mar 05, 2025 at 10:44:40AM +0530, shravan kumar wrote:
> From: Shravan Chippa <shravan.chippa@microchip.com>
>
> correcting the CPWAIT_TIME value as per the data sheet
> for the link frequency and input clock
>
> Signed-off-by: Shravan Chippa <shravan.chippa@microchip.com>
I've postponed applying this one once we have a better understanding what
that change actually is and why Tarang would seem to want to revert it.
> ---
> drivers/media/i2c/imx334.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c
> index db61b298ceb3..0b42bc0470a1 100644
> --- a/drivers/media/i2c/imx334.c
> +++ b/drivers/media/i2c/imx334.c
> @@ -191,7 +191,7 @@ static const struct imx334_reg common_mode_regs[] = {
> {0x31a0, 0x20},
> {0x31a1, 0x0f},
> {0x300c, 0x3b},
> - {0x300d, 0x29},
> + {0x300d, 0x2a},
> {0x314c, 0x29},
> {0x314d, 0x01},
> {0x315a, 0x06},
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2025-03-11 9:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 5:14 [PATCH V7 0/4] media: i2c: imx334: Add support for 1280x720 & 640x480 resolutions shravan kumar
2025-03-05 5:14 ` [PATCH V7 1/4] media: i2c: imx334: Optimized 4k and 2k mode register arrays shravan kumar
2025-03-05 5:14 ` [PATCH V7 2/4] media: i2c: imx334: common reg value correction shravan kumar
2025-03-11 9:47 ` Sakari Ailus [this message]
2025-03-11 10:09 ` Tarang Raval
2025-03-05 5:14 ` [PATCH V7 3/4] media: i2c: imx334: update mode_3840x2160_regs array shravan kumar
2025-03-05 5:14 ` [PATCH V7 4/4] media: i2c: imx334: add modes for 720p and 480p resolutions shravan kumar
2025-03-05 9:35 ` Kieran Bingham
2025-03-05 10:22 ` Shravan.Chippa
2025-03-05 10:40 ` Tarang Raval
2025-03-05 10:49 ` Kieran Bingham
2025-03-05 11:30 ` Tarang Raval
2025-03-05 12:09 ` Kieran Bingham
2025-03-05 10:45 ` Kieran Bingham
2025-03-05 11:50 ` Sakari Ailus
2025-03-05 12:16 ` Kieran Bingham
2025-03-05 12:59 ` Dave Stevenson
2025-03-06 5:15 ` Shravan.Chippa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9AGxJuk7V-QPKW1@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=conor.dooley@microchip.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=praveen.kumar@microchip.com \
--cc=shravan.chippa@microchip.com \
--cc=valentina.fernandezalanis@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®