From: Herbert Xu <herbert@gondor.apana.org.au>
To: Jia Jie Ho <jiajie.ho@starfivetech.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Conor Dooley <conor.dooley@microchip.com>,
linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v3 4/4] crypto: starfive - Add hash and HMAC support
Date: Fri, 24 Mar 2023 17:48:45 +0800 [thread overview]
Message-ID: <ZB1x/bUdOSWzim+8@gondor.apana.org.au> (raw)
In-Reply-To: <20230313135646.2077707-5-jiajie.ho@starfivetech.com>
On Mon, Mar 13, 2023 at 09:56:46PM +0800, Jia Jie Ho wrote:
>
> +static int starfive_hash_copy_sgs(struct starfive_cryp_request_ctx *rctx)
> +{
> + void *buf_in;
> + int pages, total_in;
> +
> + if (!starfive_hash_check_io_aligned(rctx)) {
> + rctx->sgs_copied = 0;
> + return 0;
> + }
> +
> + total_in = ALIGN(rctx->total, rctx->blksize);
> + pages = total_in ? get_order(total_in) : 1;
> + buf_in = (void *)__get_free_pages(GFP_ATOMIC, pages);
Please don't allocate the whole thing because it could be unlimited
in size (and triggered from user-space by untrusted users too).
If you have to copy, then just allocate a single page and copy
that, hash, and then repeat until it's all done.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2023-03-24 9:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 13:56 [PATCH v3 0/4] crypto: starfive - Add drivers for crypto engine Jia Jie Ho
2023-03-13 13:56 ` [PATCH v3 1/4] dt-bindings: crypto: Add StarFive crypto module Jia Jie Ho
2023-03-13 13:56 ` [PATCH v3 2/4] crypto: starfive - Add crypto engine support Jia Jie Ho
2023-03-13 13:56 ` [PATCH v3 3/4] riscv: dts: starfive: Add crypto and DMA node for VisionFive 2 Jia Jie Ho
2023-03-13 13:56 ` [PATCH v3 4/4] crypto: starfive - Add hash and HMAC support Jia Jie Ho
2023-03-24 9:44 ` Herbert Xu
2023-03-27 3:12 ` JiaJie Ho
2023-03-24 9:48 ` Herbert Xu [this message]
2023-03-24 9:50 ` Herbert Xu
2023-03-24 9:52 ` Herbert Xu
[not found] ` <20230314001744.1911-1-hdanton@sina.com>
2023-03-14 3:24 ` JiaJie Ho
2023-03-24 4:51 ` [PATCH v3 0/4] crypto: starfive - Add drivers for crypto engine JiaJie Ho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZB1x/bUdOSWzim+8@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=conor.dooley@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=jiajie.ho@starfivetech.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®