From: JiaJie Ho <jiajie.ho@starfivetech.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S . Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Conor Dooley <conor.dooley@microchip.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Subject: RE: [PATCH v3 4/4] crypto: starfive - Add hash and HMAC support
Date: Mon, 27 Mar 2023 03:12:36 +0000 [thread overview]
Message-ID: <436f7f43f79b43209d3477c9d99addf6@EXMBX168.cuchost.com> (raw)
In-Reply-To: <ZB1w5G5XpaQkfqZi@gondor.apana.org.au>
> On Mon, Mar 13, 2023 at 09:56:46PM +0800, Jia Jie Ho wrote:
> >
> > +static void starfive_hash_dma_callback(void *param) {
> > + struct starfive_cryp_dev *cryp = param;
> > +
> > + complete(&cryp->tx_comp);
> > +}
>
> Please get rid of tx_comp and do the rest of the processing here.
Hi Herbert,
Thanks for reviewing the patch.
I'll update this in next version.
Best regards,
Jia Jie
next prev parent reply other threads:[~2023-03-27 3:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 13:56 [PATCH v3 0/4] crypto: starfive - Add drivers for crypto engine Jia Jie Ho
2023-03-13 13:56 ` [PATCH v3 1/4] dt-bindings: crypto: Add StarFive crypto module Jia Jie Ho
2023-03-13 13:56 ` [PATCH v3 2/4] crypto: starfive - Add crypto engine support Jia Jie Ho
2023-03-13 13:56 ` [PATCH v3 3/4] riscv: dts: starfive: Add crypto and DMA node for VisionFive 2 Jia Jie Ho
2023-03-13 13:56 ` [PATCH v3 4/4] crypto: starfive - Add hash and HMAC support Jia Jie Ho
2023-03-24 9:44 ` Herbert Xu
2023-03-27 3:12 ` JiaJie Ho [this message]
2023-03-24 9:48 ` Herbert Xu
2023-03-24 9:50 ` Herbert Xu
2023-03-24 9:52 ` Herbert Xu
[not found] ` <20230314001744.1911-1-hdanton@sina.com>
2023-03-14 3:24 ` JiaJie Ho
2023-03-24 4:51 ` [PATCH v3 0/4] crypto: starfive - Add drivers for crypto engine JiaJie Ho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=436f7f43f79b43209d3477c9d99addf6@EXMBX168.cuchost.com \
--to=jiajie.ho@starfivetech.com \
--cc=conor.dooley@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®