* [PATCH] block: remove obsolete config BLOCK_COMPAT
@ 2023-03-16 11:16 Lukas Bulwahn
2023-03-16 11:29 ` Arnd Bergmann
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Lukas Bulwahn @ 2023-03-16 11:16 UTC (permalink / raw)
To: Jens Axboe, Arnd Bergmann, linux-block
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
Before commit bdc1ddad3e5f ("compat_ioctl: block: move
blkdev_compat_ioctl() into ioctl.c"), the config BLOCK_COMPAT was used to
include compat_ioctl.c into the kernel build. With this commit, the code
is moved into ioctl.c and included with the config COMPAT. So, since then,
the config BLOCK_COMPAT has no effect and any further purpose.
Remove this obsolete config BLOCK_COMPAT.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
block/Kconfig | 3 ---
1 file changed, 3 deletions(-)
diff --git a/block/Kconfig b/block/Kconfig
index 5d9d9c84d516..941b2dca70db 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -204,9 +204,6 @@ config BLK_INLINE_ENCRYPTION_FALLBACK
source "block/partitions/Kconfig"
-config BLOCK_COMPAT
- def_bool COMPAT
-
config BLK_MQ_PCI
def_bool PCI
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] block: remove obsolete config BLOCK_COMPAT
2023-03-16 11:16 [PATCH] block: remove obsolete config BLOCK_COMPAT Lukas Bulwahn
@ 2023-03-16 11:29 ` Arnd Bergmann
2023-03-16 15:15 ` Christoph Hellwig
2023-03-16 15:35 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2023-03-16 11:29 UTC (permalink / raw)
To: Lukas Bulwahn, Jens Axboe, linux-block; +Cc: kernel-janitors, linux-kernel
On Thu, Mar 16, 2023, at 12:16, Lukas Bulwahn wrote:
> Before commit bdc1ddad3e5f ("compat_ioctl: block: move
> blkdev_compat_ioctl() into ioctl.c"), the config BLOCK_COMPAT was used to
> include compat_ioctl.c into the kernel build. With this commit, the code
> is moved into ioctl.c and included with the config COMPAT. So, since then,
> the config BLOCK_COMPAT has no effect and any further purpose.
>
> Remove this obsolete config BLOCK_COMPAT.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Thanks for spotting this,
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] block: remove obsolete config BLOCK_COMPAT
2023-03-16 11:16 [PATCH] block: remove obsolete config BLOCK_COMPAT Lukas Bulwahn
2023-03-16 11:29 ` Arnd Bergmann
@ 2023-03-16 15:15 ` Christoph Hellwig
2023-03-16 15:35 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2023-03-16 15:15 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Jens Axboe, Arnd Bergmann, linux-block, kernel-janitors, linux-kernel
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] block: remove obsolete config BLOCK_COMPAT
2023-03-16 11:16 [PATCH] block: remove obsolete config BLOCK_COMPAT Lukas Bulwahn
2023-03-16 11:29 ` Arnd Bergmann
2023-03-16 15:15 ` Christoph Hellwig
@ 2023-03-16 15:35 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2023-03-16 15:35 UTC (permalink / raw)
To: Arnd Bergmann, linux-block, Lukas Bulwahn; +Cc: kernel-janitors, linux-kernel
On Thu, 16 Mar 2023 12:16:30 +0100, Lukas Bulwahn wrote:
> Before commit bdc1ddad3e5f ("compat_ioctl: block: move
> blkdev_compat_ioctl() into ioctl.c"), the config BLOCK_COMPAT was used to
> include compat_ioctl.c into the kernel build. With this commit, the code
> is moved into ioctl.c and included with the config COMPAT. So, since then,
> the config BLOCK_COMPAT has no effect and any further purpose.
>
> Remove this obsolete config BLOCK_COMPAT.
>
> [...]
Applied, thanks!
[1/1] block: remove obsolete config BLOCK_COMPAT
commit: 8f0d196e4dc137470bbd5de98278d941c8002fcb
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-16 15:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-16 11:16 [PATCH] block: remove obsolete config BLOCK_COMPAT Lukas Bulwahn
2023-03-16 11:29 ` Arnd Bergmann
2023-03-16 15:15 ` Christoph Hellwig
2023-03-16 15:35 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®