* [PATCH v1 1/1] scripts: merge_config: Fix typo in variable name.
@ 2023-03-22 8:51 Mirsad Goran Todorovac
2023-03-22 13:18 ` Mark Brown
2023-03-22 15:20 ` Randy Dunlap
0 siblings, 2 replies; 7+ messages in thread
From: Mirsad Goran Todorovac @ 2023-03-22 8:51 UTC (permalink / raw)
To: Mark Brown, linux-kbuild, linux-kernel
Cc: Masahiro Yamada, Mirsad Goran Todorovac
${WARNOVERRIDE} was misspelled as ${WARNOVVERIDE}, which caused a shell
syntax error in certain paths of the script execution.
Cc: Mark Brown <broonie@kernel.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-of-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
---
scripts/kconfig/merge_config.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh
index 32620de473ad..902eb429b9db 100755
--- a/scripts/kconfig/merge_config.sh
+++ b/scripts/kconfig/merge_config.sh
@@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do
NEW_VAL=$(grep -w $CFG $MERGE_FILE)
BUILTIN_FLAG=false
if [ "$BUILTIN" = "true" ] && [ "${NEW_VAL#CONFIG_*=}" = "m" ] && [ "${PREV_VAL#CONFIG_*=}" = "y" ]; then
- ${WARNOVVERIDE} Previous value: $PREV_VAL
+ ${WARNOVERRIDE} Previous value: $PREV_VAL
${WARNOVERRIDE} New value: $NEW_VAL
${WARNOVERRIDE} -y passed, will not demote y to m
${WARNOVERRIDE}
--
2.30.2
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v1 1/1] scripts: merge_config: Fix typo in variable name.
2023-03-22 8:51 [PATCH v1 1/1] scripts: merge_config: Fix typo in variable name Mirsad Goran Todorovac
@ 2023-03-22 13:18 ` Mark Brown
2023-03-22 14:26 ` Mirsad Goran Todorovac
2023-03-22 15:20 ` Randy Dunlap
1 sibling, 1 reply; 7+ messages in thread
From: Mark Brown @ 2023-03-22 13:18 UTC (permalink / raw)
To: Mirsad Goran Todorovac; +Cc: linux-kbuild, linux-kernel, Masahiro Yamada
[-- Attachment #1: Type: text/plain, Size: 268 bytes --]
On Wed, Mar 22, 2023 at 09:51:07AM +0100, Mirsad Goran Todorovac wrote:
> ${WARNOVERRIDE} was misspelled as ${WARNOVVERIDE}, which caused a shell
> syntax error in certain paths of the script execution.
Reviewed-by: Mark Brown <broonie@kernel.org>
Sorry about that.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v1 1/1] scripts: merge_config: Fix typo in variable name.
2023-03-22 13:18 ` Mark Brown
@ 2023-03-22 14:26 ` Mirsad Goran Todorovac
0 siblings, 0 replies; 7+ messages in thread
From: Mirsad Goran Todorovac @ 2023-03-22 14:26 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-kbuild, linux-kernel, Masahiro Yamada
On 3/22/2023 14:18, Mark Brown wrote:
> On Wed, Mar 22, 2023 at 09:51:07AM +0100, Mirsad Goran Todorovac wrote:
>> ${WARNOVERRIDE} was misspelled as ${WARNOVVERIDE}, which caused a shell
>> syntax error in certain paths of the script execution.
>
> Reviewed-by: Mark Brown <broonie@kernel.org>
>
> Sorry about that.
You shouldn't be. Errare humanum est.
I had worse blunders in the last couple of months, i.e.
setting chattr +a on log files until /var/log filled up (old logs couldn't
have been rotated).
Best regards,
Mirsad
--
Mirsad Goran Todorovac
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu
--
System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb, Republic of Croatia
tel. +385 (0)1 3711 451
mob. +385 91 57 88 355
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 1/1] scripts: merge_config: Fix typo in variable name.
2023-03-22 8:51 [PATCH v1 1/1] scripts: merge_config: Fix typo in variable name Mirsad Goran Todorovac
2023-03-22 13:18 ` Mark Brown
@ 2023-03-22 15:20 ` Randy Dunlap
2023-03-22 18:14 ` Mirsad Goran Todorovac
1 sibling, 1 reply; 7+ messages in thread
From: Randy Dunlap @ 2023-03-22 15:20 UTC (permalink / raw)
To: Mirsad Goran Todorovac, Mark Brown, linux-kbuild, linux-kernel
Cc: Masahiro Yamada
On 3/22/23 01:51, Mirsad Goran Todorovac wrote:
> ${WARNOVERRIDE} was misspelled as ${WARNOVVERIDE}, which caused a shell
> syntax error in certain paths of the script execution.
>
Fixes: 46dff8d7e381e ("scripts: merge_config: Add option to suppress warning on overrides")
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Cc: linux-kbuild@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-of-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
> ---
> scripts/kconfig/merge_config.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh
> index 32620de473ad..902eb429b9db 100755
> --- a/scripts/kconfig/merge_config.sh
> +++ b/scripts/kconfig/merge_config.sh
> @@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do
> NEW_VAL=$(grep -w $CFG $MERGE_FILE)
> BUILTIN_FLAG=false
> if [ "$BUILTIN" = "true" ] && [ "${NEW_VAL#CONFIG_*=}" = "m" ] && [ "${PREV_VAL#CONFIG_*=}" = "y" ]; then
> - ${WARNOVVERIDE} Previous value: $PREV_VAL
> + ${WARNOVERRIDE} Previous value: $PREV_VAL
> ${WARNOVERRIDE} New value: $NEW_VAL
> ${WARNOVERRIDE} -y passed, will not demote y to m
> ${WARNOVERRIDE}
--
~Randy
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v1 1/1] scripts: merge_config: Fix typo in variable name.
2023-03-22 15:20 ` Randy Dunlap
@ 2023-03-22 18:14 ` Mirsad Goran Todorovac
2023-03-23 6:24 ` Masahiro Yamada
0 siblings, 1 reply; 7+ messages in thread
From: Mirsad Goran Todorovac @ 2023-03-22 18:14 UTC (permalink / raw)
To: Randy Dunlap, Mark Brown, linux-kbuild, linux-kernel; +Cc: Masahiro Yamada
On 22. 03. 2023. 16:20, Randy Dunlap wrote:
>
>
> On 3/22/23 01:51, Mirsad Goran Todorovac wrote:
>> ${WARNOVERRIDE} was misspelled as ${WARNOVVERIDE}, which caused a shell
>> syntax error in certain paths of the script execution.
>>
>
> Fixes: 46dff8d7e381e ("scripts: merge_config: Add option to suppress warning on overrides")
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
> Thanks.
Hi, Randy,
I think this time thanks go to the Heavens, for preserving my physical integrity.
Though I don't know of a bike with ABS.
>> Cc: Mark Brown <broonie@kernel.org>
>> Cc: Masahiro Yamada <masahiroy@kernel.org>
>> Cc: linux-kbuild@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org
>> Signed-of-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
>> ---
>> scripts/kconfig/merge_config.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh
>> index 32620de473ad..902eb429b9db 100755
>> --- a/scripts/kconfig/merge_config.sh
>> +++ b/scripts/kconfig/merge_config.sh
>> @@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do
>> NEW_VAL=$(grep -w $CFG $MERGE_FILE)
>> BUILTIN_FLAG=false
>> if [ "$BUILTIN" = "true" ] && [ "${NEW_VAL#CONFIG_*=}" = "m" ] && [ "${PREV_VAL#CONFIG_*=}" = "y" ]; then
>> - ${WARNOVVERIDE} Previous value: $PREV_VAL
>> + ${WARNOVERRIDE} Previous value: $PREV_VAL
>> ${WARNOVERRIDE} New value: $NEW_VAL
>> ${WARNOVERRIDE} -y passed, will not demote y to m
>> ${WARNOVERRIDE}
Best regards,
Mirsad
--
Mirsad Goran Todorovac
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu
System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb, Republic of Croatia
The European Union
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v1 1/1] scripts: merge_config: Fix typo in variable name.
2023-03-22 18:14 ` Mirsad Goran Todorovac
@ 2023-03-23 6:24 ` Masahiro Yamada
2023-03-23 7:17 ` Mirsad Goran Todorovac
0 siblings, 1 reply; 7+ messages in thread
From: Masahiro Yamada @ 2023-03-23 6:24 UTC (permalink / raw)
To: Mirsad Goran Todorovac
Cc: Randy Dunlap, Mark Brown, linux-kbuild, linux-kernel
On Thu, Mar 23, 2023 at 3:15 AM Mirsad Goran Todorovac
<mirsad.todorovac@alu.unizg.hr> wrote:
>
> On 22. 03. 2023. 16:20, Randy Dunlap wrote:
> >
> >
> > On 3/22/23 01:51, Mirsad Goran Todorovac wrote:
> >> ${WARNOVERRIDE} was misspelled as ${WARNOVVERIDE}, which caused a shell
> >> syntax error in certain paths of the script execution.
> >>
> >
> > Fixes: 46dff8d7e381e ("scripts: merge_config: Add option to suppress warning on overrides")
> >
> > Acked-by: Randy Dunlap <rdunlap@infradead.org>
> >
> > Thanks.
>
> Hi, Randy,
>
> I think this time thanks go to the Heavens, for preserving my physical integrity.
>
> Though I don't know of a bike with ABS.
Applied to linux-kbuild/fixes,
fixing another typo "Signed-of-by".
You do not need to spell it out by yourself.
"git commit -s" will insert the Signed-off-by tag.
> >> Cc: Mark Brown <broonie@kernel.org>
> >> Cc: Masahiro Yamada <masahiroy@kernel.org>
> >> Cc: linux-kbuild@vger.kernel.org
> >> Cc: linux-kernel@vger.kernel.org
> >> Signed-of-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
> >> ---
> >> scripts/kconfig/merge_config.sh | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh
> >> index 32620de473ad..902eb429b9db 100755
> >> --- a/scripts/kconfig/merge_config.sh
> >> +++ b/scripts/kconfig/merge_config.sh
> >> @@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do
> >> NEW_VAL=$(grep -w $CFG $MERGE_FILE)
> >> BUILTIN_FLAG=false
> >> if [ "$BUILTIN" = "true" ] && [ "${NEW_VAL#CONFIG_*=}" = "m" ] && [ "${PREV_VAL#CONFIG_*=}" = "y" ]; then
> >> - ${WARNOVVERIDE} Previous value: $PREV_VAL
> >> + ${WARNOVERRIDE} Previous value: $PREV_VAL
> >> ${WARNOVERRIDE} New value: $NEW_VAL
> >> ${WARNOVERRIDE} -y passed, will not demote y to m
> >> ${WARNOVERRIDE}
>
> Best regards,
> Mirsad
>
> --
> Mirsad Goran Todorovac
> Sistem inženjer
> Grafički fakultet | Akademija likovnih umjetnosti
> Sveučilište u Zagrebu
>
> System engineer
> Faculty of Graphic Arts | Academy of Fine Arts
> University of Zagreb, Republic of Croatia
> The European Union
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v1 1/1] scripts: merge_config: Fix typo in variable name.
2023-03-23 6:24 ` Masahiro Yamada
@ 2023-03-23 7:17 ` Mirsad Goran Todorovac
0 siblings, 0 replies; 7+ messages in thread
From: Mirsad Goran Todorovac @ 2023-03-23 7:17 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Randy Dunlap, Mark Brown, linux-kbuild, linux-kernel
On 23.3.2023. 7:24, Masahiro Yamada wrote:
> On Thu, Mar 23, 2023 at 3:15 AM Mirsad Goran Todorovac
> <mirsad.todorovac@alu.unizg.hr> wrote:
>>
>> On 22. 03. 2023. 16:20, Randy Dunlap wrote:
>>>
>>> On 3/22/23 01:51, Mirsad Goran Todorovac wrote:
>>>> ${WARNOVERRIDE} was misspelled as ${WARNOVVERIDE}, which caused a shell
>>>> syntax error in certain paths of the script execution.
>>>>
>>>
>>> Fixes: 46dff8d7e381e ("scripts: merge_config: Add option to suppress warning on overrides")
>>>
>>> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>>>
>>> Thanks.
>>
>> Hi, Randy,
>>
>> I think this time thanks go to the Heavens, for preserving my physical integrity.
>>
>> Though I don't know of a bike with ABS.
> Applied to linux-kbuild/fixes,
> fixing another typo "Signed-of-by".
>
> You do not need to spell it out by yourself.
>
> "git commit -s" will insert the Signed-off-by tag.
Sorry to have wasted your time and effort. A typo fixing typo.
It is visually hard to detect once it's done. :(
I'm grateful for your quality control.
Best regards,
Mirsad
>>>> Cc: Mark Brown <broonie@kernel.org>
>>>> Cc: Masahiro Yamada <masahiroy@kernel.org>
>>>> Cc: linux-kbuild@vger.kernel.org
>>>> Cc: linux-kernel@vger.kernel.org
>>>> Signed-of-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
>>>> ---
>>>> scripts/kconfig/merge_config.sh | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh
>>>> index 32620de473ad..902eb429b9db 100755
>>>> --- a/scripts/kconfig/merge_config.sh
>>>> +++ b/scripts/kconfig/merge_config.sh
>>>> @@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do
>>>> NEW_VAL=$(grep -w $CFG $MERGE_FILE)
>>>> BUILTIN_FLAG=false
>>>> if [ "$BUILTIN" = "true" ] && [ "${NEW_VAL#CONFIG_*=}" = "m" ] && [ "${PREV_VAL#CONFIG_*=}" = "y" ]; then
>>>> - ${WARNOVVERIDE} Previous value: $PREV_VAL
>>>> + ${WARNOVERRIDE} Previous value: $PREV_VAL
>>>> ${WARNOVERRIDE} New value: $NEW_VAL
>>>> ${WARNOVERRIDE} -y passed, will not demote y to m
>>>> ${WARNOVERRIDE}
--
Mirsad Todorovac
System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb
Republic of Croatia, the European Union
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-03-23 7:18 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-22 8:51 [PATCH v1 1/1] scripts: merge_config: Fix typo in variable name Mirsad Goran Todorovac
2023-03-22 13:18 ` Mark Brown
2023-03-22 14:26 ` Mirsad Goran Todorovac
2023-03-22 15:20 ` Randy Dunlap
2023-03-22 18:14 ` Mirsad Goran Todorovac
2023-03-23 6:24 ` Masahiro Yamada
2023-03-23 7:17 ` Mirsad Goran Todorovac
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®