mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xu Yilun <yilun.xu@intel.com>
To: Marco Pagani <marpagan@redhat.com>
Cc: Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
	Tom Rix <trix@redhat.com>,
	linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fpga: bridge: fix kernel-doc
Date: Sun, 2 Apr 2023 14:36:09 +0800	[thread overview]
Message-ID: <ZCkiWfQQsFEaHm4K@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <20230330174505.158920-1-marpagan@redhat.com>

On 2023-03-30 at 19:45:05 +0200, Marco Pagani wrote:
> Fix the following warnings issued by the kernel-doc script:
> 
> drivers/fpga/fpga-bridge.c:99: warning: No description found for return value of 'of_fpga_bridge_get'
> drivers/fpga/fpga-bridge.c:163: warning: No description found for return value of 'fpga_bridges_enable'
> drivers/fpga/fpga-bridge.c:187: warning: No description found for return value of 'fpga_bridges_disable'
> drivers/fpga/fpga-bridge.c:238: warning: No description found for return value of 'of_fpga_bridge_get_to_list'
> drivers/fpga/fpga-bridge.c:268: warning: No description found for return value of 'fpga_bridge_get_to_list'

I see you are trying to clean up the warnings, but I found more in
drivers/fpga. Could you help at least fix all core code,
(of-)fpga-bridge/region/mgr.c/h in series? Thanks.

> 
> The patch is based on top of 38dbcd697770 ("fpga: bridge: fix kernel-doc parameter description").

I didn't found this commit, could you elaborate? And you could put this
info in changelog, don't show it up in mainline.

Thanks,
Yilun

  reply	other threads:[~2023-04-02  6:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-30 17:45 Marco Pagani
2023-04-02  6:36 ` Xu Yilun [this message]
2023-04-03  9:59   ` Marco Pagani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZCkiWfQQsFEaHm4K@yilunxu-OptiPlex-7050 \
    --to=yilun.xu@intel.com \
    --cc=hao.wu@intel.com \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marpagan@redhat.com \
    --cc=mdf@kernel.org \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®