From: Jason Gunthorpe <jgg@nvidia.com>
To: liulongfang <liulongfang@huawei.com>
Cc: alex.williamson@redhat.com, shameerali.kolothum.thodi@huawei.com,
jonathan.cameron@huawei.com, cohuck@redhat.com,
linux-kernel@vger.kernel.org, linuxarm@openeuler.org
Subject: Re: [PATCH v10 5/5] vfio: update live migration device status
Date: Fri, 21 Apr 2023 11:30:13 -0300 [thread overview]
Message-ID: <ZEKd9Rnt9rT0aAHh@nvidia.com> (raw)
In-Reply-To: <fe02f34a-c3d9-056a-3081-58605e8e1247@huawei.com>
On Fri, Apr 21, 2023 at 11:07:53AM +0800, liulongfang wrote:
> On 2023/4/14 20:25, Jason Gunthorpe write:
> > On Sat, Apr 08, 2023 at 03:42:24PM +0800, Longfang Liu wrote:
> >> migration debugfs needs to perform debug operations based on the
> >> status of the current device. If the device is not loaded or has
> >> stopped, debugfs does not allow operations.
> >>
> >> so, after the live migration function is executed and the device is
> >> turned off, the device no longer needs to be accessed. At this time,
> >> the status of the device needs to be set to stop.
> >
> > STOP means the devices isn't functioning
> > > An idle device that has just been reset is RUNNING by definiton.
> >
>
> After the vfio device is opened, it will be set to RUNNING, and after it
> is closed, it should be set to STOP according to the function of the
> device.
No, VFIO does not STOP anything, RUNNING means the PCI function is
operating normally, which is always how VFIO leaves it when the FD is
closed.
Jason
prev parent reply other threads:[~2023-04-21 14:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-08 7:42 [PATCH v10 0/5] add debugfs to migration driver Longfang Liu
2023-04-08 7:42 ` [PATCH v10 1/5] vfio/migration: Add debugfs to live " Longfang Liu
2023-04-08 7:42 ` [PATCH v10 2/5] hisi_acc_vfio_pci: extract public functions for container_of Longfang Liu
2023-04-08 7:42 ` [PATCH v10 3/5] hisi_acc_vfio_pci: register debugfs for hisilicon migration driver Longfang Liu
2023-04-14 12:24 ` Jason Gunthorpe
2023-04-21 3:27 ` liulongfang
2023-04-21 3:32 ` liulongfang
2023-04-21 14:31 ` Jason Gunthorpe
2023-05-16 9:40 ` liulongfang
2023-05-16 10:50 ` liulongfang
2023-05-16 11:50 ` Jason Gunthorpe
2023-06-02 7:07 ` liulongfang
2023-04-08 7:42 ` [PATCH v10 4/5] Documentation: add debugfs description for vfio Longfang Liu
2023-04-08 7:42 ` [PATCH v10 5/5] vfio: update live migration device status Longfang Liu
2023-04-14 12:25 ` Jason Gunthorpe
2023-04-21 3:07 ` liulongfang
2023-04-21 14:30 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEKd9Rnt9rT0aAHh@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=liulongfang@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome