* [PATCH] usb: typec: mux: Remove some unneeded includes
@ 2023-04-24 8:39 Christophe JAILLET
2023-04-24 13:04 ` Heikki Krogerus
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2023-04-24 8:39 UTC (permalink / raw)
To: Heikki Krogerus, Greg Kroah-Hartman
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-usb
This driver includes many header files that are unneeded.
Remove them and add <linux/device.h> where devm_kzalloc() is defined.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Based on one of my script, this reduces the number of included files
during the build process of this file from 551 to 345.
---
drivers/usb/typec/mux/gpio-sbu-mux.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/typec/mux/gpio-sbu-mux.c b/drivers/usb/typec/mux/gpio-sbu-mux.c
index f62516dafe8f..c07856069d43 100644
--- a/drivers/usb/typec/mux/gpio-sbu-mux.c
+++ b/drivers/usb/typec/mux/gpio-sbu-mux.c
@@ -3,14 +3,11 @@
* Copyright (C) 2022 Linaro Ltd.
*/
-#include <linux/bits.h>
-#include <linux/i2c.h>
-#include <linux/kernel.h>
+#include <linux/device.h>
#include <linux/module.h>
#include <linux/mutex.h>
#include <linux/gpio/consumer.h>
#include <linux/platform_device.h>
-#include <linux/regmap.h>
#include <linux/usb/typec_dp.h>
#include <linux/usb/typec_mux.h>
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: typec: mux: Remove some unneeded includes
2023-04-24 8:39 [PATCH] usb: typec: mux: Remove some unneeded includes Christophe JAILLET
@ 2023-04-24 13:04 ` Heikki Krogerus
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Krogerus @ 2023-04-24 13:04 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Greg Kroah-Hartman, linux-kernel, kernel-janitors, linux-usb
On Mon, Apr 24, 2023 at 10:39:56AM +0200, Christophe JAILLET wrote:
> This driver includes many header files that are unneeded.
> Remove them and add <linux/device.h> where devm_kzalloc() is defined.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> Based on one of my script, this reduces the number of included files
> during the build process of this file from 551 to 345.
> ---
> drivers/usb/typec/mux/gpio-sbu-mux.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/usb/typec/mux/gpio-sbu-mux.c b/drivers/usb/typec/mux/gpio-sbu-mux.c
> index f62516dafe8f..c07856069d43 100644
> --- a/drivers/usb/typec/mux/gpio-sbu-mux.c
> +++ b/drivers/usb/typec/mux/gpio-sbu-mux.c
> @@ -3,14 +3,11 @@
> * Copyright (C) 2022 Linaro Ltd.
> */
>
> -#include <linux/bits.h>
> -#include <linux/i2c.h>
> -#include <linux/kernel.h>
> +#include <linux/device.h>
> #include <linux/module.h>
> #include <linux/mutex.h>
> #include <linux/gpio/consumer.h>
> #include <linux/platform_device.h>
> -#include <linux/regmap.h>
> #include <linux/usb/typec_dp.h>
> #include <linux/usb/typec_mux.h>
>
> --
> 2.34.1
--
heikki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-24 13:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-24 8:39 [PATCH] usb: typec: mux: Remove some unneeded includes Christophe JAILLET
2023-04-24 13:04 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®