[PATCH net-next] net: fec: remove last_bdp from fec_enet_txq_xmit_frame()

[PATCH net-next] net: fec: remove last_bdp from fec_enet_txq_xmit_frame()

[wei.fang]

From: Wei Fang <wei.fang@nxp.com>

Actually, the last_bdp is useless in fec_enet_txq_xmit_frame(),
so remove it.

Signed-off-by: Wei Fang <wei.fang@nxp.com>
---
 drivers/net/ethernet/freescale/fec_main.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 3ecf20ee5851..26fb00e0590b 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -3770,7 +3770,7 @@ static int fec_enet_txq_xmit_frame(struct fec_enet_private *fep,
 				   struct xdp_frame *frame)
 {
 	unsigned int index, status, estatus;
-	struct bufdesc *bdp, *last_bdp;
+	struct bufdesc *bdp;
 	dma_addr_t dma_addr;
 	int entries_free;
 
@@ -3782,7 +3782,6 @@ static int fec_enet_txq_xmit_frame(struct fec_enet_private *fep,
 
 	/* Fill in a Tx ring entry */
 	bdp = txq->bd.cur;
-	last_bdp = bdp;
 	status = fec16_to_cpu(bdp->cbd_sc);
 	status &= ~BD_ENET_TX_STATS;
 
@@ -3810,7 +3809,6 @@ static int fec_enet_txq_xmit_frame(struct fec_enet_private *fep,
 		ebdp->cbd_esc = cpu_to_fec32(estatus);
 	}
 
-	index = fec_enet_get_bd_index(last_bdp, &txq->bd);
 	txq->tx_skbuff[index] = NULL;
 
 	/* Send it on its way.  Tell FEC it's ready, interrupt when done,
@@ -3820,7 +3818,7 @@ static int fec_enet_txq_xmit_frame(struct fec_enet_private *fep,
 	bdp->cbd_sc = cpu_to_fec16(status);
 
 	/* If this was the last BD in the ring, start at the beginning again. */
-	bdp = fec_enet_get_nextdesc(last_bdp, &txq->bd);
+	bdp = fec_enet_get_nextdesc(bdp, &txq->bd);
 
 	txq->bd.cur = bdp;
 
-- 
2.25.1

Re: [PATCH net-next] net: fec: remove last_bdp from fec_enet_txq_xmit_frame()

[Simon Horman]

On Thu, May 25, 2023 at 04:38:24PM +0800, wei.fang@nxp.com wrote:
> From: Wei Fang <wei.fang@nxp.com>
> 
> Actually, the last_bdp is useless in fec_enet_txq_xmit_frame(),
> so remove it.

I think it would be useful to describe why it is useless.

F.e. because it is set to bdp, which doesn't change,
so bdp can be used directly instead.

> Signed-off-by: Wei Fang <wei.fang@nxp.com>

-- 
pw-bot: cr

RE: [PATCH net-next] net: fec: remove last_bdp from fec_enet_txq_xmit_frame()

[Wei Fang]

> -----Original Message-----
> From: Simon Horman <simon.horman@corigine.com>
> Sent: 2023年5月25日 17:09
> To: Wei Fang <wei.fang@nxp.com>
> Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com; Shenwei Wang <shenwei.wang@nxp.com>; Clark Wang
> <xiaoning.wang@nxp.com>; netdev@vger.kernel.org; dl-linux-imx
> <linux-imx@nxp.com>; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net-next] net: fec: remove last_bdp from
> fec_enet_txq_xmit_frame()
> 
> On Thu, May 25, 2023 at 04:38:24PM +0800, wei.fang@nxp.com wrote:
> > From: Wei Fang <wei.fang@nxp.com>
> >
> > Actually, the last_bdp is useless in fec_enet_txq_xmit_frame(), so
> > remove it.
> 
> I think it would be useful to describe why it is useless.
> 
> F.e. because it is set to bdp, which doesn't change, so bdp can be used directly
> instead.
> 
Sorry, I'll refine the commit message in the next version. Thank you!