From: Christoph Hellwig <hch@infradead.org>
To: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
Cc: arnd@arndb.de, andriy.shevchenko@intel.com,
linux-kernel@vger.kernel.org, dan.j.williams@intel.com
Subject: Re: [PATCH v2 2/2] misc: enclosure: update sysfs api
Date: Thu, 25 May 2023 02:39:36 -0700 [thread overview]
Message-ID: <ZG8s2EV0xvNH+0Cb@infradead.org> (raw)
In-Reply-To: <20230524111231.14506-3-mariusz.tkaczyk@linux.intel.com>
On Wed, May 24, 2023 at 01:12:31PM +0200, Mariusz Tkaczyk wrote:
> Use DEVICE_ATTR RW and RO macros. Update function names accordingly.
> No functional changes intended.
The subject looks a bit, I'd say something like:
"enclosure: use DEVICE_ATTR_RW* macros"
instead.
The actual changes look good to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2023-05-25 9:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 11:12 [PATCH v2 0/2] Enclosure interface cleanups Mariusz Tkaczyk
2023-05-24 11:12 ` [PATCH v2 1/2] misc: enclosure: remove get_active callback Mariusz Tkaczyk
2023-05-25 9:38 ` Christoph Hellwig
2023-05-24 11:12 ` [PATCH v2 2/2] misc: enclosure: update sysfs api Mariusz Tkaczyk
2023-05-25 9:39 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZG8s2EV0xvNH+0Cb@infradead.org \
--to=hch@infradead.org \
--cc=andriy.shevchenko@intel.com \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mariusz.tkaczyk@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®