The robot is broken (was: Re: [PATCH 1/3] USB: serial: return errors from break handling)

The robot is broken (was: Re: [PATCH 1/3] USB: serial: return errors from break handling)

[Johan Hovold]

On Sat, Jun 03, 2023 at 10:40:42AM +0800, kernel test robot wrote:
> BCC: lkp@intel.com
> CC: oe-kbuild-all@lists.linux.dev
> In-Reply-To: <20230602124642.19076-2-johan@kernel.org>
> References: <20230602124642.19076-2-johan@kernel.org>
> TO: Johan Hovold <johan@kernel.org>
> TO: Johan Hovold <johan@kernel.org>
> CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
> CC: linux-usb@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
> CC: Corey Minyard <minyard@acm.org>
> 
> Hi Johan,
> 
> kernel test robot noticed the following build warnings:

> New smatch warnings:
> drivers/usb/serial/io_edgeport.c:1601 edge_break() error: uninitialized symbol 'status'.

Thanks for the report. Now fixed up in v2:

	https://lore.kernel.org/lkml/20230604123505.4661-1-johan@kernel.org

The robot currently appears to be broken though as this report was never
sent to me or the relevant mailing lists (and I just happened to see it
by chance).

Looks like there's a stray newline in the output of your scripts which
causes the mail headers above to be included in the body instead.

Johan

Re: The robot is broken (was: Re: [PATCH 1/3] USB: serial: return errors from break handling)

[Philip Li]

On Sun, Jun 04, 2023 at 02:41:27PM +0200, Johan Hovold wrote:
> On Sat, Jun 03, 2023 at 10:40:42AM +0800, kernel test robot wrote:
> > BCC: lkp@intel.com
> > CC: oe-kbuild-all@lists.linux.dev
> > In-Reply-To: <20230602124642.19076-2-johan@kernel.org>
> > References: <20230602124642.19076-2-johan@kernel.org>
> > TO: Johan Hovold <johan@kernel.org>
> > TO: Johan Hovold <johan@kernel.org>
> > CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
> > CC: linux-usb@vger.kernel.org
> > CC: linux-kernel@vger.kernel.org
> > CC: Corey Minyard <minyard@acm.org>
> > 
> > Hi Johan,
> > 
> > kernel test robot noticed the following build warnings:
> 
> > New smatch warnings:
> > drivers/usb/serial/io_edgeport.c:1601 edge_break() error: uninitialized symbol 'status'.
> 
> Thanks for the report. Now fixed up in v2:
> 
> 	https://lore.kernel.org/lkml/20230604123505.4661-1-johan@kernel.org
> 
> The robot currently appears to be broken though as this report was never
> sent to me or the relevant mailing lists (and I just happened to see it
> by chance).

Thanks a lot Johan for checking this. For now, the bot has 2 similar mailing lists,
one is oe-kbuild-all@lists.linux.dev, which contains the high confidence report that
is sent directly to author and related CC. Another one is this oe-kbuild@lists.linux.dev,
that we will send low confidence issues here and they will only be really reported
out after manual check. So we can reduce false positives.

But sometimes, we may miss some reports of real issues, sorry about this.

> 
> Looks like there's a stray newline in the output of your scripts which
> causes the mail headers above to be included in the body instead.

Thanks, yes, this is by design, when the report is confirmed, it helps to send
out the report to actual users by removing this extra line.

> 
> Johan
> 

Re: The robot is broken (was: Re: [PATCH 1/3] USB: serial: return errors from break handling)

[Johan Hovold]

On Mon, Jun 05, 2023 at 12:30:58PM +0800, Philip Li wrote:
> On Sun, Jun 04, 2023 at 02:41:27PM +0200, Johan Hovold wrote:

> > The robot currently appears to be broken though as this report was never
> > sent to me or the relevant mailing lists (and I just happened to see it
> > by chance).
> 
> Thanks a lot Johan for checking this. For now, the bot has 2 similar mailing lists,
> one is oe-kbuild-all@lists.linux.dev, which contains the high confidence report that
> is sent directly to author and related CC. Another one is this oe-kbuild@lists.linux.dev,
> that we will send low confidence issues here and they will only be really reported
> out after manual check. So we can reduce false positives.

Ah, thanks for the explanation and sorry about the noise.

Johan

Re: The robot is broken (was: Re: [PATCH 1/3] USB: serial: return errors from break handling)

[Dan Carpenter]

On Sun, Jun 04, 2023 at 02:41:27PM +0200, Johan Hovold wrote:
> On Sat, Jun 03, 2023 at 10:40:42AM +0800, kernel test robot wrote:
> > BCC: lkp@intel.com
> > CC: oe-kbuild-all@lists.linux.dev
> > In-Reply-To: <20230602124642.19076-2-johan@kernel.org>
> > References: <20230602124642.19076-2-johan@kernel.org>
> > TO: Johan Hovold <johan@kernel.org>
> > TO: Johan Hovold <johan@kernel.org>
> > CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
> > CC: linux-usb@vger.kernel.org
> > CC: linux-kernel@vger.kernel.org
> > CC: Corey Minyard <minyard@acm.org>
> > 
> > Hi Johan,
> > 
> > kernel test robot noticed the following build warnings:
> 
> > New smatch warnings:
> > drivers/usb/serial/io_edgeport.c:1601 edge_break() error: uninitialized symbol 'status'.
> 
> Thanks for the report. Now fixed up in v2:
> 
> 	https://lore.kernel.org/lkml/20230604123505.4661-1-johan@kernel.org
> 

I'm only seeing this now after I had already forwarded the report.  I
removed the old indenting warning because that's obviously intentional.

regards,
dan carpenter