mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Francesco Dolcini <francesco@dolcini.it>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Francesco Dolcini <francesco@dolcini.it>,
	Nishanth Menon <nm@ti.com>,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/5] arm64: dts: ti: add verdin am62
Date: Thu, 15 Jun 2023 08:51:07 +0200	[thread overview]
Message-ID: <ZIq02whTEce8C1P8@francesco-nb.int.toradex.com> (raw)
In-Reply-To: <62ca6112-0aca-788e-fc9b-8a2c3ce9ba1f@ti.com>

On Thu, Jun 15, 2023 at 11:38:00AM +0530, Vignesh Raghavendra wrote:
> 
> 
> On 01/06/23 18:43, Francesco Dolcini wrote:
> 
> [...]
> 
> > +/* Verdin I2C_1 */
> > +&main_i2c1 {
> > +	status = "okay";
> > +
> > +	/* Audio Codec */
> > +	nau8822_1a: audio-codec@1a {
> > +		compatible = "nuvoton,nau8822";
> > +		reg = <0x1a>;
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_i2s1_mclk>; /* Configure AUDIO_EXT_REFCLK1 pin as output */
> > +		#sound-dai-cells = <0>;
> > +
> > +		/* POSTDIV4_16FF_MAIN_2_HSDIVOUT8_CLK -> AUDIO_EXT_REFCLK1 */
> > +		assigned-clocks = <&k3_clks 157 10>;
> > +		assigned-clock-parents = <&k3_clks 157 18>;
> > +		assigned-clock-rates = <25000000>; /* for 48KHz ± 1.7% */
> > +	};
> > +
> 
> Oops, this node fails dtbs_check
> 
> make ARCH=arm64 CROSS_COMPILE=$V8_CROSS CHECK_DTBS=y ti/k3-am625-verdin-nonwifi-dev.dtb
> 
> /work/linux/arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-dev.dtb: audio-codec@1a: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
> 	From schema: /home/a0132425/workspace/k3-next/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml
> /work/linux/arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-dev.dtb: audio-codec@1a: 'anyOf' conditional failed, one must be fixed:
> 	'clocks' is a required property
> 	'#clock-cells' is a required property
> 	From schema: /work/.local/lib/python3.10/site-packages/dtschema/schemas/clock/clock.yaml

This properties are needed here, it will not work without.

Not the expert on audio codec and sound cards DT binding, but to me this is
just the yaml not being correct.

Francesco


  reply	other threads:[~2023-06-15  6:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-01 13:13 [PATCH v2 0/5] Add Toradex Verdin AM62 Francesco Dolcini
2023-06-01 13:13 ` [PATCH v2 1/5] dt-bindings: arm: ti: add toradex,verdin-am62 et al Francesco Dolcini
2023-06-02  7:20   ` Tony Lindgren
2023-06-02  8:18     ` Francesco Dolcini
2023-06-05  4:48       ` Tony Lindgren
2023-06-01 13:13 ` [PATCH v2 2/5] arm64: defconfig: enable drivers for Verdin AM62 Francesco Dolcini
2023-06-01 13:13 ` [PATCH v2 3/5] arm64: dts: ti: add verdin am62 Francesco Dolcini
2023-06-15  6:08   ` Vignesh Raghavendra
2023-06-15  6:51     ` Francesco Dolcini [this message]
2023-06-15  7:38       ` Vignesh Raghavendra
2023-06-15  7:48         ` Francesco Dolcini
2023-06-15  9:51           ` Vignesh Raghavendra
2023-06-01 13:13 ` [PATCH v2 4/5] arm64: dts: ti: add verdin am62 dahlia Francesco Dolcini
2023-06-15  6:22   ` Vignesh Raghavendra
2023-06-15  6:30     ` Francesco Dolcini
2023-06-01 13:18 ` [PATCH v2 5/5] arm64: dts: ti: add verdin am62 yavia Francesco Dolcini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZIq02whTEce8C1P8@francesco-nb.int.toradex.com \
    --to=francesco@dolcini.it \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=francesco.dolcini@toradex.com \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®