From: Ashok Raj <ashok.raj@intel.com>
To: Sean Christopherson <seanjc@google.com>
Cc: "Ashok Raj" <ashok_raj@linux.intel.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
x86@kernel.org, "Ashok Raj" <ashok.raj@linux.intel.com>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Tony Luck" <tony.luck@intel.com>,
"Arjan van de Veen" <arjan@linux.intel.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Eric Biederman" <ebiederm@xmission.com>,
"Ashok Raj" <ashok.raj@intel.com>,
"Dhanraj, Vijay" <vijay.dhanraj@intel.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Laszlo Ersek" <lersek@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Andrea Bolognani" <abologna@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [patch 0/6] Cure kexec() vs. mwait_play_dead() troubles
Date: Fri, 16 Jun 2023 08:07:48 -0700 [thread overview]
Message-ID: <ZIx6xCgdILbjcw7H@a4bf019067fa.jf.intel.com> (raw)
In-Reply-To: <ZIFPDvsKGZ7MVSMt@google.com>
On Wed, Jun 07, 2023 at 08:46:22PM -0700, Sean Christopherson wrote:
>
> https://lore.kernel.org/all/BYAPR12MB301441A16CE6CFFE17147888A0A09@BYAPR12MB3014.namprd12.prod.outlook.com
>
> > If there is a specific test you want done, let me know.
>
> Smoke testing is all I was thinking. I wouldn't put too much effort into trying
> to make sure this all works. Like I said earlier, nice to have, but certainly not
> necessary.
+ Vijay who was helping with testing this inside the VM.
+ Paolo, Laszlo
I haven't found the exact method to test with secure boot/trusted boot yet.
But here is what we were able to test thus far.
Vijay was able to get OVMF recompiled with SMM included.
Thanks to Laszlo for pointing me in the right direction. And Paolo for
helping with some basic questions.
https://github.com/tianocore/tianocore.github.io/wiki/Testing-SMM-with-QEMU,-KVM-and-libvirt
Surprisingly SMM emulation is sadly damn good :-)
Recipe is to generate SMI by writing to port 0xb2.
- On native, this does generate a broadcast SMI, the SMI_COUNT MSR 0x34
goes up by 1 on all logical CPUs.
- Turn off SMT by #echo off > /sys/devices/system/cpu/smt/control
- Do another port 0xb2, we don't see any hangs
- Bring up SMT by echo on > control, and we can see even the offline CPUs
got the SMI as indicated by MSR 0x34. (Which is as expected)
On guest, the only difference was when we turn on HT again, waking the CPUs
from INIT, SMI_COUNT has zeroed as opposed to the native. (Which is
perfectly fine) All I was looking for was "no hang". And a normal kexec
with newly updated code works well inside a guest.
Would this qualify for the smoke test pass? I'll continue to look for a
secure boot install if this doesn't close it, just haven't landed at the
right spot yet.
--
Cheers,
Ashok
next prev parent reply other threads:[~2023-06-16 15:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-03 20:06 Thomas Gleixner
2023-06-03 20:06 ` [patch 1/6] x86/smp: Remove pointless wmb() from native_stop_other_cpus() Thomas Gleixner
2023-06-03 20:06 ` [patch 2/6] x86/smp: Acquire stopping_cpu unconditionally Thomas Gleixner
2023-06-03 20:07 ` [patch 3/6] x86/smp: Use dedicated cache-line for mwait_play_dead() Thomas Gleixner
2023-06-03 20:07 ` [patch 4/6] x86/smp: Cure kexec() vs. mwait_play_dead() breakage Thomas Gleixner
2023-06-03 20:54 ` Ashok Raj
2023-06-04 3:19 ` Ashok Raj
2023-06-05 7:41 ` Thomas Gleixner
2023-06-03 20:07 ` [patch 5/6] x86/smp: Split sending INIT IPI out into a helper function Thomas Gleixner
2023-06-04 4:02 ` Mika Penttilä
2023-06-04 10:24 ` Ashok Raj
2023-06-05 7:54 ` Thomas Gleixner
2023-06-05 8:23 ` [patch v2 " Thomas Gleixner
2023-06-03 20:07 ` [patch 6/6] x86/smp: Put CPUs into INIT on shutdown if possible Thomas Gleixner
2023-06-03 20:57 ` Ashok Raj
2023-06-05 17:41 ` [patch 0/6] Cure kexec() vs. mwait_play_dead() troubles Sean Christopherson
2023-06-05 22:41 ` Thomas Gleixner
2023-06-05 23:08 ` Sean Christopherson
2023-06-06 7:20 ` Thomas Gleixner
2023-06-07 16:21 ` Ashok Raj
2023-06-07 17:33 ` Sean Christopherson
2023-06-07 22:19 ` Ashok Raj
2023-06-08 3:46 ` Sean Christopherson
2023-06-08 4:03 ` Ashok Raj
2023-06-16 15:07 ` Ashok Raj [this message]
2023-06-16 19:00 ` Sean Christopherson
2023-06-16 19:03 ` Ashok Raj
2023-06-16 19:08 ` Sean Christopherson
2023-06-09 8:40 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIx6xCgdILbjcw7H@a4bf019067fa.jf.intel.com \
--to=ashok.raj@intel.com \
--cc=abologna@redhat.com \
--cc=arjan@linux.intel.com \
--cc=ashok.raj@linux.intel.com \
--cc=ashok_raj@linux.intel.com \
--cc=berrange@redhat.com \
--cc=dave.hansen@linux.intel.com \
--cc=ebiederm@xmission.com \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vijay.dhanraj@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome