mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Francesco Dolcini <francesco@dolcini.it>
To: Nishanth Menon <nm@ti.com>
Cc: Santosh Shilimkar <ssantosh@kernel.org>,
	Tero Kristo <kristo@kernel.org>,
	Francesco Dolcini <francesco@dolcini.it>,
	Wadim Egorov <w.egorov@phytec.de>,
	vigneshr@ti.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, d-gole@ti.com
Subject: Re: [PATCH] firmware: ti_sci: Use system_state to determine polling
Date: Mon, 19 Jun 2023 23:20:28 +0200	[thread overview]
Message-ID: <ZJDGnM7X/n4WkIFS@francesco-nb.int.toradex.com> (raw)
In-Reply-To: <20230619131236.3285069-1-nm@ti.com>

On Mon, Jun 19, 2023 at 08:12:36AM -0500, Nishanth Menon wrote:
> Commit b9e8a7d950ff ("firmware: ti_sci: Switch transport to polled
> mode during system suspend") aims to resolve issues with tisci
> operations during system suspend operation. However, the system may
> enter a no_irq stage in various other usage modes, including power-off
> and restart. To determine if polling mode is appropriate, use the
> system_state instead.
> 
> While at this, drop the unused is_suspending state variable and
> related helpers.
> 
> Reported-by: Francesco Dolcini <francesco@dolcini.it>
> Reported-by: Wadim Egorov <w.egorov@phytec.de>
> Link: https://lore.kernel.org/all/ZGeHMjlnob2GFyHF@francesco-nb.int.toradex.com/
> Signed-off-by: Nishanth Menon <nm@ti.com>

s/Link/Closes/

Fixes: b9e8a7d950ff ("firmware: ti_sci: Switch transport to polled mode during system suspend")

>  drivers/firmware/ti_sci.c | 35 ++---------------------------------
>  1 file changed, 2 insertions(+), 33 deletions(-)
> 
> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> index 039d92a595ec..dc7906e38f09 100644
> --- a/drivers/firmware/ti_sci.c
> +++ b/drivers/firmware/ti_sci.c
...
> -static DEFINE_SIMPLE_DEV_PM_OPS(ti_sci_pm_ops, ti_sci_suspend, ti_sci_resume);

You need to stop using ti_sci_pm_ops in ti_sci_driver, without this
change it does not build.

diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
index dc7906e38f09..91aaa0ca9bde 100644
--- a/drivers/firmware/ti_sci.c
+++ b/drivers/firmware/ti_sci.c
@@ -3485,7 +3485,6 @@ static struct platform_driver ti_sci_driver = {
        .driver = {
                   .name = "ti-sci",
                   .of_match_table = of_match_ptr(ti_sci_of_match),
-                  .pm = &ti_sci_pm_ops,
        },
 };


With that change I was able to do a quick test on a patched v6.4-rc7 and
it seems to solve the issue.

Tested-by: Francesco Dolcini <francesco.dolcini@toradex.com> # Toradex Verdin AM62

Francesco


      reply	other threads:[~2023-06-19 21:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-19 13:12 Nishanth Menon
2023-06-19 21:20 ` Francesco Dolcini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZJDGnM7X/n4WkIFS@francesco-nb.int.toradex.com \
    --to=francesco@dolcini.it \
    --cc=d-gole@ti.com \
    --cc=kristo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=ssantosh@kernel.org \
    --cc=vigneshr@ti.com \
    --cc=w.egorov@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®