mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] workqueue: Fix cpu_intensive_thresh_us name in help text
@ 2023-07-11 10:38 Geert Uytterhoeven
  2023-07-11 14:50 ` Randy Dunlap
  2023-07-11 21:33 ` Tejun Heo
  0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2023-07-11 10:38 UTC (permalink / raw)
  To: Tejun Heo, Lai Jiangshan, Peter Zijlstra; +Cc: linux-kernel, Geert Uytterhoeven

There exists no parameter called "cpu_intensive_threshold_us".
The actual parameter name is "cpu_intensive_thresh_us".

Fixes: 6363845005202148 ("workqueue: Report work funcs that trigger automatic CPU_INTENSIVE mechanism")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 lib/Kconfig.debug | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index c8371502b4b2e678..5da00849edebafdd 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1200,7 +1200,7 @@ config WQ_CPU_INTENSIVE_REPORT
 	help
 	  Say Y here to enable reporting of concurrency-managed per-cpu work
 	  items that hog CPUs for longer than
-	  workqueue.cpu_intensive_threshold_us. Workqueue automatically
+	  workqueue.cpu_intensive_thresh_us. Workqueue automatically
 	  detects and excludes them from concurrency management to prevent
 	  them from stalling other per-cpu work items. Occassional
 	  triggering may not necessarily indicate a problem. Repeated
-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] workqueue: Fix cpu_intensive_thresh_us name in help text
  2023-07-11 10:38 [PATCH] workqueue: Fix cpu_intensive_thresh_us name in help text Geert Uytterhoeven
@ 2023-07-11 14:50 ` Randy Dunlap
  2023-07-11 21:33 ` Tejun Heo
  1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2023-07-11 14:50 UTC (permalink / raw)
  To: Geert Uytterhoeven, Tejun Heo, Lai Jiangshan, Peter Zijlstra; +Cc: linux-kernel



On 7/11/23 03:38, Geert Uytterhoeven wrote:
> There exists no parameter called "cpu_intensive_threshold_us".
> The actual parameter name is "cpu_intensive_thresh_us".
> 
> Fixes: 6363845005202148 ("workqueue: Report work funcs that trigger automatic CPU_INTENSIVE mechanism")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  lib/Kconfig.debug | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index c8371502b4b2e678..5da00849edebafdd 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1200,7 +1200,7 @@ config WQ_CPU_INTENSIVE_REPORT
>  	help
>  	  Say Y here to enable reporting of concurrency-managed per-cpu work
>  	  items that hog CPUs for longer than
> -	  workqueue.cpu_intensive_threshold_us. Workqueue automatically
> +	  workqueue.cpu_intensive_thresh_us. Workqueue automatically
>  	  detects and excludes them from concurrency management to prevent
>  	  them from stalling other per-cpu work items. Occassional
>  	  triggering may not necessarily indicate a problem. Repeated

-- 
~Randy

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] workqueue: Fix cpu_intensive_thresh_us name in help text
  2023-07-11 10:38 [PATCH] workqueue: Fix cpu_intensive_thresh_us name in help text Geert Uytterhoeven
  2023-07-11 14:50 ` Randy Dunlap
@ 2023-07-11 21:33 ` Tejun Heo
  1 sibling, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2023-07-11 21:33 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Lai Jiangshan, Peter Zijlstra, linux-kernel

On Tue, Jul 11, 2023 at 12:38:20PM +0200, Geert Uytterhoeven wrote:
> There exists no parameter called "cpu_intensive_threshold_us".
> The actual parameter name is "cpu_intensive_thresh_us".
> 
> Fixes: 6363845005202148 ("workqueue: Report work funcs that trigger automatic CPU_INTENSIVE mechanism")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  lib/Kconfig.debug | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index c8371502b4b2e678..5da00849edebafdd 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1200,7 +1200,7 @@ config WQ_CPU_INTENSIVE_REPORT
>  	help
>  	  Say Y here to enable reporting of concurrency-managed per-cpu work
>  	  items that hog CPUs for longer than
> -	  workqueue.cpu_intensive_threshold_us. Workqueue automatically
> +	  workqueue.cpu_intensive_thresh_us. Workqueue automatically
>  	  detects and excludes them from concurrency management to prevent
>  	  them from stalling other per-cpu work items. Occassional
>  	  triggering may not necessarily indicate a problem. Repeated

Applied to wq/for-6.5-fixes.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-07-11 21:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-11 10:38 [PATCH] workqueue: Fix cpu_intensive_thresh_us name in help text Geert Uytterhoeven
2023-07-11 14:50 ` Randy Dunlap
2023-07-11 21:33 ` Tejun Heo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®