mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [net Patch v2] octeontx-af: fix hardware timestamp configuration
@ 2023-07-04  4:26 Hariprasad Kelam
  2023-07-04 14:18 ` Simon Horman
  0 siblings, 1 reply; 2+ messages in thread
From: Hariprasad Kelam @ 2023-07-04  4:26 UTC (permalink / raw)
  To: netdev, linux-kernel
  Cc: edumazet, kuba, pabeni, davem, sgoutham, lcherian, gakula,
	jerinj, sbhatta, richardcochran

MAC block on CN10K (RPM) supports hardware timestamp configuration. The
previous patch which added timestamp configuration support has a bug.
Though the netdev driver requests to disable timestamp configuration,
the driver is always enabling it.

This patch fixes the same.

Fixes: d1489208681d ("octeontx2-af: cn10k: RPM hardware timestamp configuration")
Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
Signed-off-by: Sunil Goutham <sgoutham@marvell.com>
---
v2 * tag the patch to correct tree


 drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
index 4b8559ac0404..095b2cc4a699 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
@@ -763,7 +763,7 @@ static int rvu_cgx_ptp_rx_cfg(struct rvu *rvu, u16 pcifunc, bool enable)
 	cgxd = rvu_cgx_pdata(cgx_id, rvu);

 	mac_ops = get_mac_ops(cgxd);
-	mac_ops->mac_enadis_ptp_config(cgxd, lmac_id, true);
+	mac_ops->mac_enadis_ptp_config(cgxd, lmac_id, enable);
 	/* If PTP is enabled then inform NPC that packets to be
 	 * parsed by this PF will have their data shifted by 8 bytes
 	 * and if PTP is disabled then no shift is required
--
2.17.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [net Patch v2] octeontx-af: fix hardware timestamp configuration
  2023-07-04  4:26 [net Patch v2] octeontx-af: fix hardware timestamp configuration Hariprasad Kelam
@ 2023-07-04 14:18 ` Simon Horman
  0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2023-07-04 14:18 UTC (permalink / raw)
  To: Hariprasad Kelam
  Cc: netdev, linux-kernel, edumazet, kuba, pabeni, davem, sgoutham,
	lcherian, gakula, jerinj, sbhatta, richardcochran

On Tue, Jul 04, 2023 at 09:56:53AM +0530, Hariprasad Kelam wrote:
> MAC block on CN10K (RPM) supports hardware timestamp configuration. The
> previous patch which added timestamp configuration support has a bug.
> Though the netdev driver requests to disable timestamp configuration,
> the driver is always enabling it.
> 
> This patch fixes the same.
> 
> Fixes: d1489208681d ("octeontx2-af: cn10k: RPM hardware timestamp configuration")
> Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> Signed-off-by: Sunil Goutham <sgoutham@marvell.com>
> ---
> v2 * tag the patch to correct tree

Reviewed-by: Simon Horman <simon.horman@corigine.com>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-04 14:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-04  4:26 [net Patch v2] octeontx-af: fix hardware timestamp configuration Hariprasad Kelam
2023-07-04 14:18 ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®