From: Xu Yilun <yilun.xu@intel.com>
To: Yangtao Li <frank.li@vivo.com>
Cc: Wu Hao <hao.wu@intel.com>, Tom Rix <trix@redhat.com>,
Moritz Fischer <mdf@kernel.org>,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/8] fpga: dfl-fme-mgr: Convert to devm_platform_ioremap_resource()
Date: Mon, 10 Jul 2023 16:39:02 +0800 [thread overview]
Message-ID: <ZKvDpkSNt5aTQXhs@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <20230705094655.44753-3-frank.li@vivo.com>
On 2023-07-05 at 17:46:50 +0800, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Applied.
> ---
> drivers/fpga/dfl-fme-mgr.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/fpga/dfl-fme-mgr.c b/drivers/fpga/dfl-fme-mgr.c
> index af0785783b52..ab228d8837a0 100644
> --- a/drivers/fpga/dfl-fme-mgr.c
> +++ b/drivers/fpga/dfl-fme-mgr.c
> @@ -280,7 +280,6 @@ static int fme_mgr_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> struct fme_mgr_priv *priv;
> struct fpga_manager *mgr;
> - struct resource *res;
>
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> if (!priv)
> @@ -290,8 +289,7 @@ static int fme_mgr_probe(struct platform_device *pdev)
> priv->ioaddr = pdata->ioaddr;
>
> if (!priv->ioaddr) {
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->ioaddr = devm_ioremap_resource(dev, res);
> + priv->ioaddr = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->ioaddr))
> return PTR_ERR(priv->ioaddr);
> }
> --
> 2.39.0
>
next prev parent reply other threads:[~2023-07-10 8:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 9:46 [PATCH 1/8] fpga: bridge: " Yangtao Li
2023-07-05 9:46 ` [PATCH 2/8] fpga: fpga-mgr: altera-pr-ip: " Yangtao Li
2023-07-10 8:30 ` Xu Yilun
2023-07-05 9:46 ` [PATCH 3/8] fpga: dfl-fme-mgr: " Yangtao Li
2023-07-10 8:39 ` Xu Yilun [this message]
2023-07-05 9:46 ` [PATCH 4/8] fpga: socfpga-a10: " Yangtao Li
2023-07-10 8:36 ` Xu Yilun
2023-07-05 9:46 ` [PATCH 5/8] fpga: xilinx-pr-decoupler: " Yangtao Li
2023-07-07 4:55 ` Michal Simek
2023-07-10 8:42 ` Xu Yilun
2023-07-05 9:46 ` [PATCH 6/8] fpga: fpga-mgr: socfpga: " Yangtao Li
2023-07-10 8:47 ` Xu Yilun
2023-07-05 9:46 ` [PATCH 7/8] fpga: fpga-mgr: ts73xx: " Yangtao Li
2023-07-10 8:52 ` Xu Yilun
2023-07-05 9:46 ` [PATCH 8/8] fpga: zynq-fpga: " Yangtao Li
2023-07-07 4:55 ` Michal Simek
2023-07-10 8:54 ` Xu Yilun
2023-07-10 8:38 ` [PATCH 1/8] fpga: bridge: " Xu Yilun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKvDpkSNt5aTQXhs@yilunxu-OptiPlex-7050 \
--to=yilun.xu@intel.com \
--cc=frank.li@vivo.com \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®