* [PATCH] MIPS: prefer 'unsigned int' to bare use of 'unsigned' [not found] <20230709141701.16324-1-denghuilong@cdjrlc.com> @ 2023-07-09 14:19 ` xuanzhenggang001 2023-07-11 11:53 ` Philippe Mathieu-Daudé 2023-07-25 8:45 ` Thomas Bogendoerfer 0 siblings, 2 replies; 3+ messages in thread From: xuanzhenggang001 @ 2023-07-09 14:19 UTC (permalink / raw) To: tsbogend; +Cc: linux-mips, linux-kernel Fix the following warnings reported by checkpatch: arch/mips/kernel/linux32.c:128: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Zhenggang Xuan <xuanzhenggang001@208suo.com> --- arch/mips/kernel/linux32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/mips/kernel/linux32.c b/arch/mips/kernel/linux32.c index 6b61be486303..4bd52b38dd00 100644 --- a/arch/mips/kernel/linux32.c +++ b/arch/mips/kernel/linux32.c @@ -125,8 +125,8 @@ asmlinkage long sys32_fadvise64_64(int fd, int __pad, flags); } -asmlinkage long sys32_fallocate(int fd, int mode, unsigned offset_a2, - unsigned offset_a3, unsigned len_a4, unsigned len_a5) +asmlinkage long sys32_fallocate(int fd, int mode, unsigned int offset_a2, + unsigned int offset_a3, unsigned int len_a4, unsigned int len_a5) { return ksys_fallocate(fd, mode, merge_64(offset_a2, offset_a3), merge_64(len_a4, len_a5)); ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: prefer 'unsigned int' to bare use of 'unsigned' 2023-07-09 14:19 ` [PATCH] MIPS: prefer 'unsigned int' to bare use of 'unsigned' xuanzhenggang001 @ 2023-07-11 11:53 ` Philippe Mathieu-Daudé 2023-07-25 8:45 ` Thomas Bogendoerfer 1 sibling, 0 replies; 3+ messages in thread From: Philippe Mathieu-Daudé @ 2023-07-11 11:53 UTC (permalink / raw) To: xuanzhenggang001, tsbogend; +Cc: linux-mips, linux-kernel On 9/7/23 16:19, xuanzhenggang001@208suo.com wrote: > Fix the following warnings reported by checkpatch: > > arch/mips/kernel/linux32.c:128: WARNING: Prefer 'unsigned int' to bare > use of 'unsigned' > arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare > use of 'unsigned' > arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare > use of 'unsigned' > arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare > use of 'unsigned' > > Signed-off-by: Zhenggang Xuan <xuanzhenggang001@208suo.com> > --- > arch/mips/kernel/linux32.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: prefer 'unsigned int' to bare use of 'unsigned' 2023-07-09 14:19 ` [PATCH] MIPS: prefer 'unsigned int' to bare use of 'unsigned' xuanzhenggang001 2023-07-11 11:53 ` Philippe Mathieu-Daudé @ 2023-07-25 8:45 ` Thomas Bogendoerfer 1 sibling, 0 replies; 3+ messages in thread From: Thomas Bogendoerfer @ 2023-07-25 8:45 UTC (permalink / raw) To: xuanzhenggang001; +Cc: linux-mips, linux-kernel On Sun, Jul 09, 2023 at 10:19:50PM +0800, xuanzhenggang001@208suo.com wrote: > Fix the following warnings reported by checkpatch: > > arch/mips/kernel/linux32.c:128: WARNING: Prefer 'unsigned int' to bare use > of 'unsigned' > arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use > of 'unsigned' > arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use > of 'unsigned' > arch/mips/kernel/linux32.c:129: WARNING: Prefer 'unsigned int' to bare use > of 'unsigned' > > Signed-off-by: Zhenggang Xuan <xuanzhenggang001@208suo.com> > --- > arch/mips/kernel/linux32.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/mips/kernel/linux32.c b/arch/mips/kernel/linux32.c > index 6b61be486303..4bd52b38dd00 100644 > --- a/arch/mips/kernel/linux32.c > +++ b/arch/mips/kernel/linux32.c > @@ -125,8 +125,8 @@ asmlinkage long sys32_fadvise64_64(int fd, int __pad, > flags); > } > > -asmlinkage long sys32_fallocate(int fd, int mode, unsigned offset_a2, > - unsigned offset_a3, unsigned len_a4, unsigned len_a5) > +asmlinkage long sys32_fallocate(int fd, int mode, unsigned int offset_a2, > + unsigned int offset_a3, unsigned int len_a4, unsigned int len_a5) > { > return ksys_fallocate(fd, mode, merge_64(offset_a2, offset_a3), > merge_64(len_a4, len_a5)); this is white-space damaged, please resend with that corrected. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-25 9:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230709141701.16324-1-denghuilong@cdjrlc.com>
2023-07-09 14:19 ` [PATCH] MIPS: prefer 'unsigned int' to bare use of 'unsigned' xuanzhenggang001
2023-07-11 11:53 ` Philippe Mathieu-Daudé
2023-07-25 8:45 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®