From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: hdegoede@redhat.com, markgross@kernel.org,
ilpo.jarvinen@linux.intel.com,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/3] TPMI control and debugfs support
Date: Thu, 13 Jul 2023 19:48:53 +0300 [thread overview]
Message-ID: <ZLAq9YnaQ5XPsiZG@smile.fi.intel.com> (raw)
In-Reply-To: <20230712225950.171326-1-srinivas.pandruvada@linux.intel.com>
On Wed, Jul 12, 2023 at 03:59:47PM -0700, Srinivas Pandruvada wrote:
> The first patch provides interface to read feature status. This is
> generic patch to be used by other feature drivers.
>
> The second patch add support for debugfs. Debugfs also display
> feature status using the first patch
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
A couple of nit-picks in the individual comments.
> Srinivas Pandruvada (3):
> platform/x86/intel/tpmi: Read feature control status
> platform/x86/intel/tpmi: Add debugfs interface
> doc: TPMI: Add debugfs documentation
>
> Documentation/ABI/testing/debugfs-tpmi | 31 ++
> MAINTAINERS | 1 +
> drivers/platform/x86/intel/tpmi.c | 399 ++++++++++++++++++++++++-
> include/linux/intel_tpmi.h | 2 +
> 4 files changed, 426 insertions(+), 7 deletions(-)
> create mode 100644 Documentation/ABI/testing/debugfs-tpmi
>
> --
> 2.40.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-07-13 16:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 22:59 Srinivas Pandruvada
2023-07-12 22:59 ` [PATCH v3 1/3] platform/x86/intel/tpmi: Read feature control status Srinivas Pandruvada
2023-07-13 16:44 ` Andy Shevchenko
2023-07-12 22:59 ` [PATCH v3 2/3] platform/x86/intel/tpmi: Add debugfs interface Srinivas Pandruvada
2023-07-13 16:48 ` Andy Shevchenko
2023-07-12 22:59 ` [PATCH v3 3/3] doc: TPMI: Add debugfs documentation Srinivas Pandruvada
2023-07-13 16:48 ` Andy Shevchenko [this message]
2023-07-14 13:27 ` [PATCH v3 0/3] TPMI control and debugfs support Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLAq9YnaQ5XPsiZG@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome