[PATCH] mm/rmap: correct stale comment of rmap_walk_anon and rmap_walk_file

[PATCH] mm/rmap: correct stale comment of rmap_walk_anon and rmap_walk_file

[Kemeng Shi]

1. update page to folio in comment
2. add comment of new added @locked

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
 mm/rmap.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/mm/rmap.c b/mm/rmap.c
index 2668f5ea3534..1c0538fbb8f2 100644
--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -2402,11 +2402,12 @@ static struct anon_vma *rmap_walk_anon_lock(struct folio *folio,
 /*
  * rmap_walk_anon - do something to anonymous page using the object-based
  * rmap method
- * @page: the page to be handled
+ * @folio: the folio to be handled
  * @rwc: control variable according to each walk type
+ * @locked: caller holds relevant rmap lock
  *
- * Find all the mappings of a page using the mapping pointer and the vma chains
- * contained in the anon_vma struct it points to.
+ * Find all the mappings of a folio using the mapping pointer and the vma
+ * chains contained in the anon_vma struct it points to.
  */
 static void rmap_walk_anon(struct folio *folio,
 		struct rmap_walk_control *rwc, bool locked)
@@ -2450,10 +2451,11 @@ static void rmap_walk_anon(struct folio *folio,
 
 /*
  * rmap_walk_file - do something to file page using the object-based rmap method
- * @page: the page to be handled
+ * @folio: the folio to be handled
  * @rwc: control variable according to each walk type
+ * @locked: caller holds relevant rmap lock
  *
- * Find all the mappings of a page using the mapping pointer and the vma chains
+ * Find all the mappings of a folio using the mapping pointer and the vma chains
  * contained in the address_space struct it points to.
  */
 static void rmap_walk_file(struct folio *folio,
-- 
2.30.0

Re: [PATCH] mm/rmap: correct stale comment of rmap_walk_anon and rmap_walk_file

[David Hildenbrand]

On 18.07.23 11:21, Kemeng Shi wrote:
> 1. update page to folio in comment
> 2. add comment of new added @locked
> 
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
> ---


Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb

Re: [PATCH] mm/rmap: correct stale comment of rmap_walk_anon and rmap_walk_file

[Matthew Wilcox]

On Tue, Jul 18, 2023 at 12:10:27PM +0200, David Hildenbrand wrote:
> On 18.07.23 11:21, Kemeng Shi wrote:
> > 1. update page to folio in comment
> > 2. add comment of new added @locked
> > 
> > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
> > ---
> 
> 
> Reviewed-by: David Hildenbrand <david@redhat.com>

I didn't get the original email, and it's also not in the lore
archives:

https://lore.kernel.org/linux-mm/76de1682-353b-b8e9-0f09-539988f8ffe0@redhat.com/T/#u

Can someone send it along?

Re: [PATCH] mm/rmap: correct stale comment of rmap_walk_anon and rmap_walk_file

[David Hildenbrand]

On 18.07.23 14:43, Matthew Wilcox wrote:
> On Tue, Jul 18, 2023 at 12:10:27PM +0200, David Hildenbrand wrote:
>> On 18.07.23 11:21, Kemeng Shi wrote:
>>> 1. update page to folio in comment
>>> 2. add comment of new added @locked
>>>
>>> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
>>> ---
>>
>>
>> Reviewed-by: David Hildenbrand <david@redhat.com>
> 
> I didn't get the original email, and it's also not in the lore
> archives:
> 
> https://lore.kernel.org/linux-mm/76de1682-353b-b8e9-0f09-539988f8ffe0@redhat.com/T/#u
> 
> Can someone send it along?
> 

Not sure what went wrong there:

https://lore.kernel.org/all/20230718092136.1935789-1-shikemeng@huaweicloud.com/T/#u

-- 
Cheers,

David / dhildenb

Re: [PATCH] mm/rmap: correct stale comment of rmap_walk_anon and rmap_walk_file

[Matthew Wilcox]

On Tue, Jul 18, 2023 at 02:46:07PM +0200, David Hildenbrand wrote:
> https://lore.kernel.org/all/20230718092136.1935789-1-shikemeng@huaweicloud.com/T/#u

Looks like kvack.org rejected or delayed it.  Anyway, patch is fine, so

Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>