* [PATCH] drm/panel: JDI LT070ME05000 remove useless warning
@ 2022-02-06 19:07 David Heidelberg
2022-02-06 19:26 ` Sam Ravnborg
0 siblings, 1 reply; 3+ messages in thread
From: David Heidelberg @ 2022-02-06 19:07 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter
Cc: ~okias/devicetree, David Heidelberg, dri-devel, linux-kernel
Do as most of panel and in case of deffered probe, don't print error.
Fixes warning:
panel-jdi-lt070me05000 4700000.dsi.0: cannot get enable-gpio -517
Signed-off-by: David Heidelberg <david@ixit.cz>
---
drivers/gpu/drm/panel/panel-jdi-lt070me05000.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c
index ea0e7221e706..b5c0b51dc146 100644
--- a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c
+++ b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c
@@ -408,7 +408,8 @@ static int jdi_panel_add(struct jdi_panel *jdi)
jdi->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW);
if (IS_ERR(jdi->enable_gpio)) {
ret = PTR_ERR(jdi->enable_gpio);
- dev_err(dev, "cannot get enable-gpio %d\n", ret);
+ if (ret != -EPROBE_DEFER)
+ dev_err(dev, "cannot get enable-gpio %d\n", ret);
return ret;
}
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panel: JDI LT070ME05000 remove useless warning
2022-02-06 19:07 [PATCH] drm/panel: JDI LT070ME05000 remove useless warning David Heidelberg
@ 2022-02-06 19:26 ` Sam Ravnborg
2022-02-06 19:40 ` David Heidelberg
0 siblings, 1 reply; 3+ messages in thread
From: Sam Ravnborg @ 2022-02-06 19:26 UTC (permalink / raw)
To: David Heidelberg
Cc: Thierry Reding, David Airlie, Daniel Vetter, dri-devel,
~okias/devicetree, linux-kernel
Hi David,
On Sun, Feb 06, 2022 at 08:07:02PM +0100, David Heidelberg wrote:
> Do as most of panel and in case of deffered probe, don't print error.
>
> Fixes warning:
> panel-jdi-lt070me05000 4700000.dsi.0: cannot get enable-gpio -517
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> drivers/gpu/drm/panel/panel-jdi-lt070me05000.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c
> index ea0e7221e706..b5c0b51dc146 100644
> --- a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c
> +++ b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c
> @@ -408,7 +408,8 @@ static int jdi_panel_add(struct jdi_panel *jdi)
> jdi->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW);
> if (IS_ERR(jdi->enable_gpio)) {
> ret = PTR_ERR(jdi->enable_gpio);
> - dev_err(dev, "cannot get enable-gpio %d\n", ret);
> + if (ret != -EPROBE_DEFER)
> + dev_err(dev, "cannot get enable-gpio %d\n", ret);
> return ret;
> }
Thanks for submitting a fix for this.
Please look into the use of dev_err_probe() for this as this is the
preferred way to fix it now.
Sam
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panel: JDI LT070ME05000 remove useless warning
2022-02-06 19:26 ` Sam Ravnborg
@ 2022-02-06 19:40 ` David Heidelberg
0 siblings, 0 replies; 3+ messages in thread
From: David Heidelberg @ 2022-02-06 19:40 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Thierry Reding, David Airlie, Daniel Vetter, dri-devel,
~okias/devicetree, linux-kernel
On Sun, Feb 6 2022 at 20:26:50 +0100, Sam Ravnborg <sam@ravnborg.org>
wrote:
> dev_err_probe
Amazing, thanks I'll send fix right away.
Davi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-06 19:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-06 19:07 [PATCH] drm/panel: JDI LT070ME05000 remove useless warning David Heidelberg
2022-02-06 19:26 ` Sam Ravnborg
2022-02-06 19:40 ` David Heidelberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®