* [PATCH net v2] nl80211/cfg80211: add forgetten nla_policy for BSS color attribute
@ 2023-08-09 3:31 Lin Ma
2023-08-10 14:25 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Lin Ma @ 2023-08-09 3:31 UTC (permalink / raw)
To: johannes, davem, edumazet, kuba, pabeni, avraham.stern,
luciano.coelho, linux-wireless, netdev, linux-kernel
Cc: Lin Ma
The previous commit dd3e4fc75b4a ("nl80211/cfg80211: add BSS color to
NDP ranging parameters") adds a parameter for NDP ranging by introducing
a new attribute type named NL80211_PMSR_FTM_REQ_ATTR_BSS_COLOR.
However, the author forgot to also describe the nla_policy at
nl80211_pmsr_ftm_req_attr_policy (net/wireless/nl80211.c). Just
complement it to avoid malformed attribute that causes out-of-attribute
access.
Fixes: dd3e4fc75b4a ("nl80211/cfg80211: add BSS color to NDP ranging parameters")
Signed-off-by: Lin Ma <linma@zju.edu.cn>
---
v1 -> v2: resent due to the last version failed to reach public mail
list.
net/wireless/nl80211.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 0da2e6a2a7ea..f729dba1cb5b 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -323,6 +323,7 @@ nl80211_pmsr_ftm_req_attr_policy[NL80211_PMSR_FTM_REQ_ATTR_MAX + 1] = {
[NL80211_PMSR_FTM_REQ_ATTR_TRIGGER_BASED] = { .type = NLA_FLAG },
[NL80211_PMSR_FTM_REQ_ATTR_NON_TRIGGER_BASED] = { .type = NLA_FLAG },
[NL80211_PMSR_FTM_REQ_ATTR_LMR_FEEDBACK] = { .type = NLA_FLAG },
+ [NL80211_PMSR_FTM_REQ_ATTR_BSS_COLOR] = { .type = NLA_U8 },
};
static const struct nla_policy
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH net v2] nl80211/cfg80211: add forgetten nla_policy for BSS color attribute
2023-08-09 3:31 [PATCH net v2] nl80211/cfg80211: add forgetten nla_policy for BSS color attribute Lin Ma
@ 2023-08-10 14:25 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2023-08-10 14:25 UTC (permalink / raw)
To: Lin Ma
Cc: johannes, davem, edumazet, kuba, pabeni, avraham.stern,
luciano.coelho, linux-wireless, netdev, linux-kernel
On Wed, Aug 09, 2023 at 11:31:51AM +0800, Lin Ma wrote:
> The previous commit dd3e4fc75b4a ("nl80211/cfg80211: add BSS color to
> NDP ranging parameters") adds a parameter for NDP ranging by introducing
> a new attribute type named NL80211_PMSR_FTM_REQ_ATTR_BSS_COLOR.
>
> However, the author forgot to also describe the nla_policy at
> nl80211_pmsr_ftm_req_attr_policy (net/wireless/nl80211.c). Just
> complement it to avoid malformed attribute that causes out-of-attribute
> access.
>
> Fixes: dd3e4fc75b4a ("nl80211/cfg80211: add BSS color to NDP ranging parameters")
> Signed-off-by: Lin Ma <linma@zju.edu.cn>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-10 14:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-09 3:31 [PATCH net v2] nl80211/cfg80211: add forgetten nla_policy for BSS color attribute Lin Ma
2023-08-10 14:25 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®